Re: [PATCH v5 1/5] powerpc/85xx: implement hardware timebase sync

2012-06-06 Thread Zhao Chenhui
On Wed, Jun 06, 2012 at 01:26:16PM -0500, Scott Wood wrote: > On 06/06/2012 04:31 AM, Zhao Chenhui wrote: > > On Tue, Jun 05, 2012 at 11:07:41AM -0500, Scott Wood wrote: > >> On 06/05/2012 04:08 AM, Zhao Chenhui wrote: > >>> On Fri, Jun 01, 2012 at 10:40:00AM -0500, Scott Wood wrote: > I know

Re: [PATCH v5 1/5] powerpc/85xx: implement hardware timebase sync

2012-06-06 Thread Scott Wood
On 06/06/2012 04:31 AM, Zhao Chenhui wrote: > On Tue, Jun 05, 2012 at 11:07:41AM -0500, Scott Wood wrote: >> On 06/05/2012 04:08 AM, Zhao Chenhui wrote: >>> On Fri, Jun 01, 2012 at 10:40:00AM -0500, Scott Wood wrote: I know you say this is for dual-core chips only, but it would be nice if

Re: [PATCH v5 1/5] powerpc/85xx: implement hardware timebase sync

2012-06-06 Thread Zhao Chenhui
On Tue, Jun 05, 2012 at 11:07:41AM -0500, Scott Wood wrote: > On 06/05/2012 04:08 AM, Zhao Chenhui wrote: > > On Fri, Jun 01, 2012 at 10:40:00AM -0500, Scott Wood wrote: > >> I know you say this is for dual-core chips only, but it would be nice if > >> you'd write this in a way that doesn't assume

Re: [PATCH v5 1/5] powerpc/85xx: implement hardware timebase sync

2012-06-05 Thread Scott Wood
On 06/05/2012 04:08 AM, Zhao Chenhui wrote: > On Fri, Jun 01, 2012 at 10:40:00AM -0500, Scott Wood wrote: >> I know you say this is for dual-core chips only, but it would be nice if >> you'd write this in a way that doesn't assume that (even if the >> corenet-specific timebase freezing comes later)

Re: [PATCH v5 1/5] powerpc/85xx: implement hardware timebase sync

2012-06-05 Thread Zhao Chenhui
On Fri, Jun 01, 2012 at 10:40:00AM -0500, Scott Wood wrote: > On 05/11/2012 06:53 AM, Zhao Chenhui wrote: > > #ifdef CONFIG_KEXEC > > +static struct ccsr_guts __iomem *guts; > > +static u64 timebase; > > +static int tb_req; > > +static int tb_valid; > > + > > +static void mpc85xx_timebase_freeze(i

Re: [PATCH v5 1/5] powerpc/85xx: implement hardware timebase sync

2012-06-01 Thread Scott Wood
On 05/11/2012 06:53 AM, Zhao Chenhui wrote: > #ifdef CONFIG_KEXEC > +static struct ccsr_guts __iomem *guts; > +static u64 timebase; > +static int tb_req; > +static int tb_valid; > + > +static void mpc85xx_timebase_freeze(int freeze) Why is this under CONFIG_KEXEC? It'll also be needed for CPU ho

Re: [PATCH v5 1/5] powerpc/85xx: implement hardware timebase sync

2012-05-29 Thread Li Yang
Hi Scott, Thanks for the valuable comment raised before and we have updated the patches accordingly. Please review the updated patch set and ACK if they are good to you. We hope it can be applied in this window. Leo On Fri, May 11, 2012 at 7:53 PM, Zhao Chenhui wrote: > Do hardware timebase s