Re: [PATCH v4 1/5] powerpc/lib/sstep: Add cmpb instruction emulation

2017-08-01 Thread Matt Brown
On Tue, Aug 1, 2017 at 10:44 PM, Segher Boessenkool wrote: > Hi! > > On Mon, Jul 31, 2017 at 10:58:22AM +1000, Matt Brown wrote: >> @@ -1049,6 +1065,10 @@ int analyse_instr(struct instruction_op *op, struct >> pt_regs *regs, >> do_cmp_unsigned(regs, val, val2, rd >> 2); >>

Re: [PATCH v4 1/5] powerpc/lib/sstep: Add cmpb instruction emulation

2017-08-01 Thread Segher Boessenkool
Hi! On Mon, Jul 31, 2017 at 10:58:22AM +1000, Matt Brown wrote: > @@ -1049,6 +1065,10 @@ int analyse_instr(struct instruction_op *op, struct > pt_regs *regs, > do_cmp_unsigned(regs, val, val2, rd >> 2); > goto instr_done; > > + case 508: /

Re: [PATCH v4 1/5] powerpc/lib/sstep: Add cmpb instruction emulation

2017-07-30 Thread Cyril Bur
On Mon, 2017-07-31 at 10:58 +1000, Matt Brown wrote: > This patch adds emulation of the cmpb instruction, enabling xmon to > emulate this instruction. > Tested for correctness against the cmpb asm instruction on ppc64le. > > Signed-off-by: Matt Brown Reviewed-by: Cyril Bur > --- > v2: >