Re: [PATCH v4 02/23] mm/gup: factor out duplicate code from four routines

2019-11-13 Thread John Hubbard
On 11/13/19 3:15 AM, Jan Kara wrote: On Tue 12-11-19 20:26:49, John Hubbard wrote: There are four locations in gup.c that have a fair amount of code duplication. This means that changing one requires making the same changes in four places, not to mention reading the same code four times, and won

Re: [PATCH v4 02/23] mm/gup: factor out duplicate code from four routines

2019-11-13 Thread Jan Kara
On Tue 12-11-19 20:26:49, John Hubbard wrote: > There are four locations in gup.c that have a fair amount of code > duplication. This means that changing one requires making the same > changes in four places, not to mention reading the same code four > times, and wondering if there are subtle diffe