Re: [PATCH v3 2/8] mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES

2024-08-06 Thread Peter Xu
On Tue, Aug 06, 2024 at 06:32:10PM +0200, David Hildenbrand wrote: > On 06.08.24 18:26, Peter Xu wrote: > > On Tue, Aug 06, 2024 at 03:02:00PM +0200, David Hildenbrand wrote: > > > > Right. > > > > > > > > I don't have a reason to change numa_pte_updates semantics yet so far, > > > > but > > > >

Re: [PATCH v3 2/8] mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES

2024-08-06 Thread David Hildenbrand
On 06.08.24 18:26, Peter Xu wrote: On Tue, Aug 06, 2024 at 03:02:00PM +0200, David Hildenbrand wrote: Right. I don't have a reason to change numa_pte_updates semantics yet so far, but here there's the problem where numa_huge_pte_updates can be ambiguous when there is even PUD involved. In gene

Re: [PATCH v3 2/8] mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES

2024-08-06 Thread Peter Xu
On Tue, Aug 06, 2024 at 03:02:00PM +0200, David Hildenbrand wrote: > > Right. > > > > I don't have a reason to change numa_pte_updates semantics yet so far, but > > here there's the problem where numa_huge_pte_updates can be ambiguous when > > there is even PUD involved. > > > > In general, I don

Re: [PATCH v3 2/8] mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES

2024-08-06 Thread David Hildenbrand
Right. I don't have a reason to change numa_pte_updates semantics yet so far, but here there's the problem where numa_huge_pte_updates can be ambiguous when there is even PUD involved. In general, I don't know how I should treat this counter in PUD path even if NUMA isn't involved in dax yet; it

Re: [PATCH v3 2/8] mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES

2024-08-04 Thread Peter Xu
On Wed, Jul 31, 2024 at 02:18:26PM +0200, David Hildenbrand wrote: > On 15.07.24 21:21, Peter Xu wrote: > > In 2013, commit 72403b4a0fbd ("mm: numa: return the number of base pages > > altered by protection changes") introduced "numa_huge_pte_updates" vmstat > > entry, trying to capture how many hu

Re: [PATCH v3 2/8] mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES

2024-07-31 Thread David Hildenbrand
On 15.07.24 21:21, Peter Xu wrote: In 2013, commit 72403b4a0fbd ("mm: numa: return the number of base pages altered by protection changes") introduced "numa_huge_pte_updates" vmstat entry, trying to capture how many huge ptes (in reality, PMD thps at that time) are marked by NUMA balancing. This