Re: [PATCH v3 16/18] jbd2: switch to using the crc32c library

2024-11-04 Thread Eric Biggers
On Mon, Nov 04, 2024 at 08:01:36AM -0800, Darrick J. Wong wrote: > Same comment as my last reply about removing trivial helpers, but > otherwise > Reviewed-by: Darrick J. Wong > > If you push this for 6.13 I'd be happy that the shash junk finally went > away. The onstack struct desc thing in the

Re: [PATCH v3 16/18] jbd2: switch to using the crc32c library

2024-11-04 Thread Theodore Ts'o
On Sun, Nov 03, 2024 at 02:31:52PM -0800, Eric Biggers wrote: > From: Eric Biggers > > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32c(). This is much simpler, and it impr

Re: [PATCH v3 16/18] jbd2: switch to using the crc32c library

2024-11-04 Thread Darrick J. Wong
On Sun, Nov 03, 2024 at 02:31:52PM -0800, Eric Biggers wrote: > From: Eric Biggers > > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32c(). This is much simpler, and it impr