Re: [PATCH v3 02/12] powerpc: wiiu: device tree

2022-06-29 Thread Segher Boessenkool
On Wed, Jun 29, 2022 at 08:13:13PM +0200, Krzysztof Kozlowski wrote: > On 29/06/2022 18:13, Segher Boessenkool wrote: > > On Wed, Jun 29, 2022 at 11:58:18AM +0200, Krzysztof Kozlowski wrote: > >>> + /* TODO: Add SMP */ > >>> + PowerPC,espresso@0 { > >> > >> Node name should be gener

Re: [PATCH v3 02/12] powerpc: wiiu: device tree

2022-06-29 Thread Krzysztof Kozlowski
On 29/06/2022 18:13, Segher Boessenkool wrote: > On Wed, Jun 29, 2022 at 11:58:18AM +0200, Krzysztof Kozlowski wrote: >> On 28/06/2022 15:31, Ash Logan wrote: >>> + model = "nintendo,wiiu"; >> >> It's not compatible, but user-visible string, e.g. "Nintendo Wii U" > > The "model" property in OF i

Re: [PATCH v3 02/12] powerpc: wiiu: device tree

2022-06-29 Thread Segher Boessenkool
On Wed, Jun 29, 2022 at 11:58:18AM +0200, Krzysztof Kozlowski wrote: > On 28/06/2022 15:31, Ash Logan wrote: > > + model = "nintendo,wiiu"; > > It's not compatible, but user-visible string, e.g. "Nintendo Wii U" The "model" property in OF is documented as: --- “model”

Re: [PATCH v3 02/12] powerpc: wiiu: device tree

2022-06-29 Thread Krzysztof Kozlowski
On 28/06/2022 15:31, Ash Logan wrote: > Add a device tree source file for the Nintendo Wii U video game console. > > Signed-off-by: Ash Logan > Co-developed-by: Roberto Van Eeden > Signed-off-by: Roberto Van Eeden > Co-developed-by: Emmanuel Gil Peyrot > Signed-off-by: Emmanuel Gil Peyrot > -