Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Timur Tabi
Anton Vorontsov wrote: >> struct ucc_geth { >> struct ucc_fast uccf; >> +u8 res9[0x100 - sizeof(struct ucc_fast)]; >> u32 maccfg1;/* mac configuration reg. 1 */ >> u32 maccfg2;/* mac configuration reg. 2 */ >> > > This fixed issue, much thanks. Gr

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Anton Vorontsov
On Wed, Oct 03, 2007 at 10:01:48AM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > >> Ok, thanks anyway, will look further as time will permit. > > I think I found it. Of course, if I'm right, then that doesn't explain how > the 8360 works. > > In struct ucc_geth, add this: > > struct ucc_ge

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Timur Tabi
Anton Vorontsov wrote: > Ok, thanks anyway, will look further as time will permit. I think I found it. Of course, if I'm right, then that doesn't explain how the 8360 works. In struct ucc_geth, add this: struct ucc_geth { struct ucc_fast uccf; + u8 res9[0x100 - sizeof(str

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Kumar Gala
On Oct 3, 2007, at 9:39 AM, Timur Tabi wrote: > Anton Vorontsov wrote: > >> Doubtfully, if changes are completely transparent. Because >> everything works >> here without that cleanup. >> >> Ok, thanks anyway, will look further as time will permit. > > I did have one idea - the programming of t

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Timur Tabi
Anton Vorontsov wrote: > Doubtfully, if changes are completely transparent. Because everything works > here without that cleanup. > > Ok, thanks anyway, will look further as time will permit. I did have one idea - the programming of the GUEMR register in ucc_fast_init() could be wrong. Can do

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Anton Vorontsov
On Wed, Oct 03, 2007 at 09:16:51AM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: >> Hi Timur, >> On Thu, Sep 20, 2007 at 03:47:26PM -0500, Timur Tabi wrote: >>> This patch makes numerous miscellaneous code improvements to the QE >>> library. >> ...and also breaks MPC8568E-MDS. ;-) Board hangs

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Timur Tabi
Anton Vorontsov wrote: > Hi Timur, > > On Thu, Sep 20, 2007 at 03:47:26PM -0500, Timur Tabi wrote: >> This patch makes numerous miscellaneous code improvements to the QE library. > > ...and also breaks MPC8568E-MDS. ;-) Board hangs just after ip-config stuff. > > Commit 589ffa1c520355e37d5868 in

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Anton Vorontsov
Hi Timur, On Thu, Sep 20, 2007 at 03:47:26PM -0500, Timur Tabi wrote: > This patch makes numerous miscellaneous code improvements to the QE library. ...and also breaks MPC8568E-MDS. ;-) Board hangs just after ip-config stuff. Commit 589ffa1c520355e37d5868 in galak/powerpc.git. Unfortunately it

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-09-20 Thread Kumar Gala
On Sep 20, 2007, at 4:30 PM, Timur Tabi wrote: > Timur Tabi wrote: >> This patch makes numerous miscellaneous code improvements to the >> QE library. > > Paul and Kumar, > > Unless there are any other suggestions for improvements, this is > the version I'd like applied. Thanks. Ok, I'll tak

Re: [PATCH v3] qe: miscellaneous code improvements and fixes to the QE library

2007-09-20 Thread Timur Tabi
Timur Tabi wrote: > This patch makes numerous miscellaneous code improvements to the QE library. Paul and Kumar, Unless there are any other suggestions for improvements, this is the version I'd like applied. Thanks. -- Timur Tabi Linux Kernel Developer @ Freescale