On Tue, 09 Jul 2024 12:28:29 +0530
Naveen N Rao wrote:
> Masami Hiramatsu wrote:
> > On Thu, 27 Jun 2024 09:21:01 -0400
> > Abhishek Dubey wrote:
> >
> >> +/* rethook initializer */
> >> +int __init arch_init_kprobes(void)
> >> +{
> >> + return register_kprobe(&trampoline_p);
> >> +}
> >
> >
Masami Hiramatsu wrote:
On Thu, 27 Jun 2024 09:21:01 -0400
Abhishek Dubey wrote:
+/* rethook initializer */
+int __init arch_init_kprobes(void)
+{
+ return register_kprobe(&trampoline_p);
+}
No, please don't use arch_init_kprobes() for initializing rethook, since
rethook is used from f
On Thu, 27 Jun 2024 09:21:01 -0400
Abhishek Dubey wrote:
> +/* rethook initializer */
> +int __init arch_init_kprobes(void)
> +{
> + return register_kprobe(&trampoline_p);
> +}
No, please don't use arch_init_kprobes() for initializing rethook, since
rethook is used from fprobe too (at this m
Hi Abhishek,
This patch looks good to me, except for one main change in
trampoline_rethook_handler().
Other than that, I have a few more minor comments. Sorry, I should have
caught that last time. But, the other change needs a new submission, so
good to get these addressed as well.
For the sub
