Re: [PATCH v2 2/3] powerpc/kprobes: un-blacklist system_call() from kprobes

2017-05-04 Thread Michael Ellerman
"Naveen N. Rao" writes: > On 2017/05/04 04:03PM, Michael Ellerman wrote: >> Would this work? >> >> diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S >> index 767ef6d68c9e..8d0fa4a2262a 100644 >> --- a/arch/powerpc/kernel/entry_64.S >> +++ b/arch/powerpc/kernel/entry_64.

Re: [PATCH v2 2/3] powerpc/kprobes: un-blacklist system_call() from kprobes

2017-05-04 Thread Naveen N. Rao
On 2017/05/04 04:03PM, Michael Ellerman wrote: > "Naveen N. Rao" writes: > > > On 2017/04/27 08:19PM, Michael Ellerman wrote: > >> "Naveen N. Rao" writes: > >> > >> > It is actually safe to probe system_call() in entry_64.S, but only till > >> > .Lsyscall_exit. To allow this, convert .Lsyscall_

Re: [PATCH v2 2/3] powerpc/kprobes: un-blacklist system_call() from kprobes

2017-05-03 Thread Michael Ellerman
"Naveen N. Rao" writes: > On 2017/04/27 08:19PM, Michael Ellerman wrote: >> "Naveen N. Rao" writes: >> >> > It is actually safe to probe system_call() in entry_64.S, but only till >> > .Lsyscall_exit. To allow this, convert .Lsyscall_exit to a non-local >> > symbol __system_call() and blacklist

Re: [PATCH v2 2/3] powerpc/kprobes: un-blacklist system_call() from kprobes

2017-04-27 Thread Naveen N. Rao
On 2017/04/27 08:19PM, Michael Ellerman wrote: > "Naveen N. Rao" writes: > > > It is actually safe to probe system_call() in entry_64.S, but only till > > .Lsyscall_exit. To allow this, convert .Lsyscall_exit to a non-local > > symbol __system_call() and blacklist that symbol, rather than > > sys

Re: [PATCH v2 2/3] powerpc/kprobes: un-blacklist system_call() from kprobes

2017-04-27 Thread Michael Ellerman
"Naveen N. Rao" writes: > It is actually safe to probe system_call() in entry_64.S, but only till > .Lsyscall_exit. To allow this, convert .Lsyscall_exit to a non-local > symbol __system_call() and blacklist that symbol, rather than > system_call(). I'm not sure I like this. The reason we made i