Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-22 Thread Eric DeVolder
On 6/22/23 11:24, Alexander Gordeev wrote: On Wed, Jun 21, 2023 at 12:10:49PM -0500, Eric DeVolder wrote: Hi Eric, ... NOTE: The original Kconfig has a KEXEC_SIG which depends on MODULE_SIG_FORMAT. However, attempts to keep the MODULE_SIG_FORMAT dependency (using the strategy outlined in this

Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-22 Thread Alexander Gordeev
On Wed, Jun 21, 2023 at 12:10:49PM -0500, Eric DeVolder wrote: Hi Eric, ... > > > NOTE: The original Kconfig has a KEXEC_SIG which depends on > > > MODULE_SIG_FORMAT. However, attempts to keep the MODULE_SIG_FORMAT > > > dependency (using the strategy outlined in this series, and other > > > techni

Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Mimi Zohar
On Wed, 2023-06-21 at 07:00 +0200, Alexander Gordeev wrote: > AFAICT the MODULE_SIG_FORMAT dependency was introduced with commit > c8424e776b09 ("MODSIGN: Export module signature definitions") and > in fact was not necessary, since s390 did/does not use mod_check_sig() > anyway. So the SYSTEM_DATA_

Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Eric DeVolder
On 6/21/23 00:00, Alexander Gordeev wrote: On Mon, Jun 19, 2023 at 10:58:00AM -0400, Eric DeVolder wrote: Hi Eric, The kexec and crash kernel options are provided in the common kernel/Kconfig.kexec. Utilize the common options and provide the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recre

Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Alexander Gordeev
On Mon, Jun 19, 2023 at 10:58:00AM -0400, Eric DeVolder wrote: Hi Eric, > The kexec and crash kernel options are provided in the common > kernel/Kconfig.kexec. Utilize the common options and provide > the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recreate the > equivalent set of KEXEC and CRASH