Re: [PATCH v2 1/4] uprobes: add trap variant helper

2013-03-26 Thread Srikar Dronamraju
* Ananth N Mavinakayanahalli [2013-03-22 20:46:27]: > From: Ananth N Mavinakayanahalli > > Some architectures like powerpc have multiple variants of the trap > instruction. Introduce an additional helper is_trap_insn() for run-time > handling of non-uprobe traps on such architectures. > > Whil

Re: [PATCH v2 1/4] uprobes: add trap variant helper

2013-03-23 Thread Oleg Nesterov
On 03/22, Ananth N Mavinakayanahalli wrote: > > Some architectures like powerpc have multiple variants of the trap > instruction. Introduce an additional helper is_trap_insn() for run-time > handling of non-uprobe traps on such architectures. Looks fine to me. I am going to take this into my tree