Re: [PATCH v2 03/30] cxlflash: Fix read capacity timeout

2015-09-21 Thread Matthew R. Ochs
> On Sep 21, 2015, at 6:36 AM, Tomas Henzl wrote: > On 16.9.2015 23:26, Matthew R. Ochs wrote: >> From: Manoj Kumar >> >> The timeout value for read capacity is too small. Certain devices >> may take longer to respond and thus the command may prematurely >> timeout. Additionally the literal used

Re: [PATCH v2 03/30] cxlflash: Fix read capacity timeout

2015-09-21 Thread Tomas Henzl
On 16.9.2015 23:26, Matthew R. Ochs wrote: > From: Manoj Kumar > > The timeout value for read capacity is too small. Certain devices > may take longer to respond and thus the command may prematurely > timeout. Additionally the literal used for the timeout is stale. > > Update the timeout to 30 sec

Re: [PATCH v2 03/30] cxlflash: Fix read capacity timeout

2015-09-17 Thread Brian King
On 09/16/2015 04:26 PM, Matthew R. Ochs wrote: > @@ -296,7 +296,7 @@ static int read_cap16(struct scsi_device *sdev, struct > llun_info *lli) > int rc = 0; > int result = 0; > int retry_cnt = 0; > - u32 tout = (MC_DISCOVERY_TIMEOUT * HZ); > + u32 to = (CMD_TIMEOUT * HZ);