Re: [PATCH v2 01/12] nios2: define virtual address space for modules

2023-06-16 Thread Mike Rapoport
On Fri, Jun 16, 2023 at 04:00:19PM +, Edgecombe, Rick P wrote: > On Fri, 2023-06-16 at 11:50 +0300, Mike Rapoport wrote: > >  void *module_alloc(unsigned long size) > >  { > > -   if (size == 0) > > -   return NULL; > > -   return kmalloc(size, GFP_KERNEL); > > -} > > - > >

Re: [PATCH v2 01/12] nios2: define virtual address space for modules

2023-06-16 Thread Song Liu
On Fri, Jun 16, 2023 at 1:51 AM Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > nios2 uses kmalloc() to implement module_alloc() because CALL26/PCREL26 > cannot reach all of vmalloc address space. > > Define module space as 32MiB below the kernel base and switch nios2 to > use vmalloc fo

Re: [PATCH v2 01/12] nios2: define virtual address space for modules

2023-06-16 Thread Edgecombe, Rick P
On Fri, 2023-06-16 at 11:50 +0300, Mike Rapoport wrote: >  void *module_alloc(unsigned long size) >  { > -   if (size == 0) > -   return NULL; > -   return kmalloc(size, GFP_KERNEL); > -} > - > -/* Free memory returned from module_alloc */ > -void module_memfree(void *module_reg