Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-07 Thread Dale Farnsworth
On Mon, Apr 07, 2008 at 03:10:09PM +0200, Johannes Berg wrote: > > Note that I've been wondering wether we should attempt to trace all > > those IRQ state change internally to the exception code. I've looked at > > not doing it, which simplifies things a bit. > > > > Unfortunately, that will make

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-07 Thread Dale Farnsworth
On Mon, Apr 07, 2008 at 02:49:51PM +1000, Benjamin Herrenschmidt wrote: > I think I found one: > > .../... > > > - mr r6,r3 > > rlwinm r12,r1,0,0,(31-THREAD_SHIFT)/* current_thread_info() */ > > /* disable interrupts so current_thread_info()->flags can't change */ > > LOA

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-07 Thread Johannes Berg
> Note that I've been wondering wether we should attempt to trace all > those IRQ state change internally to the exception code. I've looked at > not doing it, which simplifies things a bit. > > Unfortunately, that will make us occasionally trace redundant > enable/disable (which isn't a big prob

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-06 Thread Benjamin Herrenschmidt
I think I found one: .../... > - mr r6,r3 > rlwinm r12,r1,0,0,(31-THREAD_SHIFT)/* current_thread_info() */ > /* disable interrupts so current_thread_info()->flags can't change */ > LOAD_MSR_KERNEL(r10,MSR_KERNEL) /* doesn't include MSR_EE */ > SYNC > M

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Dale Farnsworth
On Sat, Apr 05, 2008 at 04:14:56PM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2008-04-05 at 01:31 +0200, Johannes Berg wrote: > > > This version takes care to save and restore *all* the volatile registers > > > around the call to trace_hardirqs_off in transfer_to_handler, and should > > > fi

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Benjamin Herrenschmidt
On Sat, 2008-04-05 at 01:31 +0200, Johannes Berg wrote: > > This version takes care to save and restore *all* the volatile registers > > around the call to trace_hardirqs_off in transfer_to_handler, and should > > fix the anomalies seen by Johannes Berg. I've tested on 7447- and 8548- > > based b

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Johannes Berg
> This version takes care to save and restore *all* the volatile registers > around the call to trace_hardirqs_off in transfer_to_handler, and should > fix the anomalies seen by Johannes Berg. I've tested on 7447- and 8548- > based boards. Still has problems on my machine. Maybe to do with non-m

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Benjamin Herrenschmidt
> Right, it's not needed on 4xx/BookE, but I didn't think it worth > optimizing at this point, since it will split the code into 4xx/BookE > and classic versions. Let's get it working solid first. Yup, it's just that I spotted it while reading the code. > That's what I originally thought and had

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Dale Farnsworth
On Sat, Apr 05, 2008 at 09:07:31AM +1100, Benjamin Herrenschmidt wrote: > > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S > > index 69a91bd..bd3ce0f 100644 > > --- a/arch/powerpc/kernel/entry_32.S > > +++ b/arch/powerpc/kernel/entry_32.S > > @@ -144,6 +144,47 @@ trans

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Benjamin Herrenschmidt
> config LOCKDEP_SUPPORT > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S > index 69a91bd..bd3ce0f 100644 > --- a/arch/powerpc/kernel/entry_32.S > +++ b/arch/powerpc/kernel/entry_32.S > @@ -144,6 +144,47 @@ transfer_to_handler: > .globl transfer_to_handler_cont