Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-12-03 Thread Michael Lawnick
Ben Dooks said the following: > On Thu, Dec 03, 2009 at 04:09:57PM +0100, Michael Lawnick wrote: >> Ben Dooks said the following: >> > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: >> >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal >> >> wrote: >> >> > This fixes MAL (arbit

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-12-03 Thread Joakim Tjernlund
> > On Thu, Dec 03, 2009 at 04:09:57PM +0100, Michael Lawnick wrote: > > Ben Dooks said the following: > > > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: > > >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > > >> wrote: > > >> > This fixes MAL (arbitration lost) bug caused

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-12-03 Thread Joakim Tjernlund
> > Ben Dooks said the following: > > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: > >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > >> wrote: > >> > This fixes MAL (arbitration lost) bug caused by illegal use of > >> > RSTA (repeated START) after STOP condition generate

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-12-03 Thread Ben Dooks
On Thu, Dec 03, 2009 at 04:09:57PM +0100, Michael Lawnick wrote: > Ben Dooks said the following: > > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: > >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > >> wrote: > >> > This fixes MAL (arbitration lost) bug caused by illegal us

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-12-03 Thread Michael Lawnick
Ben Dooks said the following: > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal >> wrote: >> > This fixes MAL (arbitration lost) bug caused by illegal use of >> > RSTA (repeated START) after STOP condition generated after last b

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-06-14 Thread Esben Haabendal
Ben Dooks wrote: is there a new version of this patch available? I will catch up on it ASAP. /Esben ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-06-14 Thread Ben Dooks
is there a new version of this patch available? -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-06-02 Thread Grant Likely
On Tue, Jun 2, 2009 at 5:12 PM, Grant Likely wrote: > Hi Esben and Ben, > > Sorry for the lateness in reviewing this.  FWIW, here are my comments. > > g. > > On Mon, May 18, 2009 at 11:22 PM, Esben Haabendal > wrote: >> This fixes MAL (arbitration lost) bug caused by illegal use of >> RSTA (repea

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-06-02 Thread Grant Likely
Hi Esben and Ben, Sorry for the lateness in reviewing this. FWIW, here are my comments. g. On Mon, May 18, 2009 at 11:22 PM, Esben Haabendal wrote: > This fixes MAL (arbitration lost) bug caused by illegal use of > RSTA (repeated START) after STOP condition generated after last byte > of reads

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-06-02 Thread Ben Dooks
On Thu, May 28, 2009 at 10:15:22PM +0200, Esben Haabendal wrote: > On Thu, May 28, 2009 at 9:31 PM, Grant Likely > wrote: > > On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal wrote: > >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal wrote: > >>> This fixes MAL (arbitration lost) bug caused by

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Esben Haabendal
Peter Korsgaard wrote: "Esben" == Esben Haabendal writes: Hi, Esben> It's strange, that line looks perfectly fine when I check the Esben> mail in my GMail inbox and the outbox from the account I sent Esben> it from. Well, it is here and in the archive: http://ozlabs.org/piper

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Peter Korsgaard
> "Esben" == Esben Haabendal writes: Hi, Esben> It's strange, that line looks perfectly fine when I check the Esben> mail in my GMail inbox and the outbox from the account I sent Esben> it from. Well, it is here and in the archive: http://ozlabs.org/pipermail/linuxppc-dev/2009-May/072274

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Esben Haabendal
>  Esben> I've checked both my copy in my "Sent" folder and the copy >  Esben> received from the list, and I cannot see any "line break" >  Esben> breakage of the patch. > > I guess Wolfram referred to the context line which was clearly word wrapped: > > @@ -456,17 +456,22 @@ static int mpc_xfer(st

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Peter Korsgaard
> "Esben" == Esben Haabendal writes: Hi, >> I wanted to test it, but it does not apply due to line breaks (check >> @@-line). Also, I don't really have the time to dig into the topic, so I >> would only test it and give a tested-by-tag if it doesn't break anything >> here. I think Joakim

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Esben Haabendal
On Thu, May 28, 2009 at 9:31 PM, Grant Likely wrote: > On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal wrote: >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal wrote: >>> This fixes MAL (arbitration lost) bug caused by illegal use of >>> RSTA (repeated START) after STOP condition generated afte

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Esben Haabendal
On Thu, May 28, 2009 at 7:17 PM, Wolfram Sang wrote: >> > Any blockers to get this accepted? >> >> It would be nice to get an ack from someone who can actually test >> the driver before getting this merged. > > I wanted to test it, but it does not apply due to line breaks (check > @@-line). Also,

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Grant Likely
On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal wrote: > On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > wrote: >> This fixes MAL (arbitration lost) bug caused by illegal use of >> RSTA (repeated START) after STOP condition generated after last byte >> of reads. With this patch, it is possib

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Joakim Tjernlund
Wolfram Sang wrote on 28/05/2009 19:17:26: > > > > Any blockers to get this accepted? > > > > It would be nice to get an ack from someone who can actually test > > the driver before getting this merged. > > I wanted to test it, but it does not apply due to line breaks (check > @@-line). Also, I do

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Wolfram Sang
> > Any blockers to get this accepted? > > It would be nice to get an ack from someone who can actually test > the driver before getting this merged. I wanted to test it, but it does not apply due to line breaks (check @@-line). Also, I don't really have the time to dig into the topic, so I would

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-26 Thread Ben Dooks
On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: > On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > wrote: > > This fixes MAL (arbitration lost) bug caused by illegal use of > > RSTA (repeated START) after STOP condition generated after last byte > > of reads. With this patch, i

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-26 Thread Esben Haabendal
On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal wrote: > This fixes MAL (arbitration lost) bug caused by illegal use of > RSTA (repeated START) after STOP condition generated after last byte > of reads. With this patch, it is possible to do an i2c_transfer() with > additional i2c_msg's following