Re: [PATCH net-next] net: use pdev instead of OF funcs

2024-11-11 Thread Rosen Penev
On Mon, Nov 11, 2024 at 8:21 AM Rob Herring wrote: > > On Sat, Nov 9, 2024 at 5:40 PM Rosen Penev wrote: > > > > np here is ofdev->dev.of_node. Better to use the proper functions as > > there's no use of children or anything else. > > Your commit message needs some work. > > > Signed-off-by: Rose

Re: [PATCH net-next] net: use pdev instead of OF funcs

2024-11-11 Thread Rob Herring
On Sat, Nov 9, 2024 at 5:40 PM Rosen Penev wrote: > > np here is ofdev->dev.of_node. Better to use the proper functions as > there's no use of children or anything else. Your commit message needs some work. > Signed-off-by: Rosen Penev > --- > drivers/net/can/grcan.c | 2

Re: [PATCH net-next] net: use pdev instead of OF funcs

2024-11-10 Thread Francois Romieu
Rosen Penev : > np here is ofdev->dev.of_node. Better to use the proper functions as > there's no use of children or anything else. > > Signed-off-by: Rosen Penev > --- [...] > diff --git a/drivers/net/ethernet/via/via-rhine.c > b/drivers/net/ethernet/via/via-rhine.c > index 894911f3d560..f0792

Re: [PATCH net-next] net: use pdev instead of OF funcs

2024-11-10 Thread kernel test robot
Hi Rosen, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/net-use-pdev-instead-of-OF-funcs/20241110-073939 base: net-next/main patch link: https://lore.kernel.org/r/202411

Re: [PATCH net-next] net: use pdev instead of OF funcs

2024-11-10 Thread kernel test robot
Hi Rosen, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/net-use-pdev-instead-of-OF-funcs/20241110-073939 base: net-next/main patch link: https://lore.kernel.org/r/2024110923