Re: [PATCH V3 15/17] riscv: compat: Add UXL_32 support in start_thread

2022-01-20 Thread Guo Ren
On Thu, Jan 20, 2022 at 9:39 PM Arnd Bergmann wrote: > > On Thu, Jan 20, 2022 at 8:39 AM wrote: > > + > > +#ifdef CONFIG_COMPAT > > + if (is_compat_task()) > > + regs->status |= SR_UXL_32; > > +#endif > > > You should not need that #ifdef, as the is_compat_task() definition is

Re: [PATCH V3 15/17] riscv: compat: Add UXL_32 support in start_thread

2022-01-20 Thread Arnd Bergmann
On Thu, Jan 20, 2022 at 8:39 AM wrote: > + > +#ifdef CONFIG_COMPAT > + if (is_compat_task()) > + regs->status |= SR_UXL_32; > +#endif You should not need that #ifdef, as the is_compat_task() definition is meant to drop the code at compile time, unless the SR_UXL_32 definition