Re: [PATCH V2 1/2] pseries/eeh: Refactor the configure bridge RTAS tokens

2016-03-29 Thread Gavin Shan
On Tue, Mar 29, 2016 at 03:53:19PM +1000, Russell Currey wrote: >On Tue, 2016-03-29 at 16:26 +1100, Gavin Shan wrote: >> On Tue, Mar 29, 2016 at 12:51:50PM +1000, Russell Currey wrote: > >> >/* >> > * Necessary sanity check. We needn't check "get-config-addr-info" >> > @@ -93,8 +98,7 @@ sta

Re: [PATCH V2 1/2] pseries/eeh: Refactor the configure bridge RTAS tokens

2016-03-28 Thread Russell Currey
On Tue, 2016-03-29 at 16:26 +1100, Gavin Shan wrote: > On Tue, Mar 29, 2016 at 12:51:50PM +1000, Russell Currey wrote: > > /* > > * Necessary sanity check. We needn't check "get-config-addr-info" > > @@ -93,8 +98,7 @@ static int pseries_eeh_init(void) > > (ibm_read_slot_reset_stat

Re: [PATCH V2 1/2] pseries/eeh: Refactor the configure bridge RTAS tokens

2016-03-28 Thread Gavin Shan
On Tue, Mar 29, 2016 at 12:51:50PM +1000, Russell Currey wrote: >The RTAS calls configure-pe and configure-bridge perform the same >actions, however the former can skip configuration if unnecessary. The >existing code treats them as different tokens even though only one will >ever be called. Refa