Re: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions

2016-04-13 Thread Boris Brezillon
Hi, On Sat, 9 Apr 2016 12:50:35 +0300 Andy Shevchenko wrote: > On Fri, Apr 8, 2016 at 2:13 PM, Rafał Miłecki wrote: > > 1) Use pr_fmt to keep messages consistent > > 2) Don't warn if kzalloc fails as it dumps stack on its own > > 3) Use %pR format for displaying whole resource to avoid: > > war

Re: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions

2016-04-09 Thread Andy Shevchenko
On Fri, Apr 8, 2016 at 2:13 PM, Rafał Miłecki wrote: > 1) Use pr_fmt to keep messages consistent > 2) Don't warn if kzalloc fails as it dumps stack on its own > 3) Use %pR format for displaying whole resource to avoid: > warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument

Re: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions

2016-04-08 Thread Joe Perches
On Fri, 2016-04-08 at 13:13 +0200, Rafał Miłecki wrote: > 1) Use pr_fmt to keep messages consistent > 2) Don't warn if kzalloc fails as it dumps stack on its own > 3) Use %pR format for displaying whole resource to avoid: > warning: format ‘%08llx’ expects type ‘long long unsigned int’, but > argum