Re: [PATCH 6/8] pseries: phyp dump: debugging print routines.

2008-01-07 Thread Stephen Rothwell
Hi Manish, Just a trivial comment. On Mon, 07 Jan 2008 18:35:09 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote: > > + printk(KERN_INFO "dump disk section = %d\n",ph->dump_disk_section); Please put a space after the ','. Here and later. -- Cheers, Stephen Rothwell[EMAIL P

Re: [PATCH 6/8] pseries: phyp dump: debugging print routines.

2008-01-07 Thread Arnd Bergmann
On Tuesday 08 January 2008, Manish Ahuja wrote: > +#ifdef DEBUG > +static void print_dump_header(const struct phyp_dump_header *ph) > +{ > +   printk(KERN_INFO "dump header:\n"); > ... > +   printk(KERN_INFO "SRSD length_copied > =%lx\n",ph->kernel_data.length_copied); > +} > +#endif > +