Re: [PATCH 6/6] s390x: Mark archrandom.h functions __must_check

2019-10-30 Thread Harald Freudenberger
On 29.10.19 14:18, Richard Henderson wrote: > On 10/29/19 8:26 AM, Harald Freudenberger wrote: >> Fine with me, Thanks, reviewed, build and tested. >> You may add my reviewed-by: Harald Freudenberger >> However, will this go into the kernel tree via crypto or s390 subsystem ? > That's an excellent

Re: [PATCH 6/6] s390x: Mark archrandom.h functions __must_check

2019-10-29 Thread Richard Henderson
On 10/29/19 8:26 AM, Harald Freudenberger wrote: > Fine with me, Thanks, reviewed, build and tested. > You may add my reviewed-by: Harald Freudenberger > However, will this go into the kernel tree via crypto or s390 subsystem ? That's an excellent question. As an API decision, perhaps going via

Re: [PATCH 6/6] s390x: Mark archrandom.h functions __must_check

2019-10-29 Thread Harald Freudenberger
On 28.10.19 22:05, Richard Henderson wrote: > We cannot use the pointer output without validating the > success of the random read. > > Signed-off-by: Richard Henderson > --- > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > --- > arch/s390/include/asm/archrandom.h | 8 +++