Re: [PATCH 4/7] powerpc/powernv: Patch MSI EOI handler on P8

2013-04-25 Thread Gavin Shan
On Thu, Apr 25, 2013 at 06:47:58PM +1000, Benjamin Herrenschmidt wrote: >On Thu, 2013-04-25 at 16:13 +0800, Gavin Shan wrote: >> It should be "chip_data" (not "irq_data"). Hopefully, you haven't >> get time to see the reply. Otherwise, it would a bit confused ;-) > >Doesn't ics-opal already use chi

Re: [PATCH 4/7] powerpc/powernv: Patch MSI EOI handler on P8

2013-04-25 Thread Benjamin Herrenschmidt
On Thu, 2013-04-25 at 16:13 +0800, Gavin Shan wrote: > It should be "chip_data" (not "irq_data"). Hopefully, you haven't > get time to see the reply. Otherwise, it would a bit confused ;-) Doesn't ics-opal already use chip_data ? I was thinking just duplicating the irq_chip (including chip_data)

Re: [PATCH 4/7] powerpc/powernv: Patch MSI EOI handler on P8

2013-04-25 Thread Gavin Shan
On Thu, Apr 25, 2013 at 04:08:37PM +0800, Gavin Shan wrote: >On Thu, Apr 25, 2013 at 06:49:40AM +1000, Benjamin Herrenschmidt wrote: >>On Wed, 2013-04-24 at 17:37 +0800, Gavin Shan wrote: >>> The EOI handler of MSI/MSI-X interrupts for P8 (PHB3) need additional >>> steps to handle the P/Q bits in I

Re: [PATCH 4/7] powerpc/powernv: Patch MSI EOI handler on P8

2013-04-25 Thread Gavin Shan
On Thu, Apr 25, 2013 at 06:49:40AM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2013-04-24 at 17:37 +0800, Gavin Shan wrote: >> The EOI handler of MSI/MSI-X interrupts for P8 (PHB3) need additional >> steps to handle the P/Q bits in IVE before EOIing the corresponding >> interrupt. The patch chang

Re: [PATCH 4/7] powerpc/powernv: Patch MSI EOI handler on P8

2013-04-24 Thread Benjamin Herrenschmidt
On Wed, 2013-04-24 at 17:37 +0800, Gavin Shan wrote: > The EOI handler of MSI/MSI-X interrupts for P8 (PHB3) need additional > steps to handle the P/Q bits in IVE before EOIing the corresponding > interrupt. The patch changes the EOI handler to cover that. .../... > static void pnv_pci_init_iod