Re: [PATCH 3/4] [POWERPC] CPM2: implement GPIO API

2007-12-21 Thread Anton Vorontsov
On Fri, Dec 21, 2007 at 10:16:32PM +0100, Arnd Bergmann wrote: > On Friday 21 December 2007, Anton Vorontsov wrote: > > > > +static spinlock_t cpm2_port_lock = __SPIN_LOCK_UNLOCKED(cpm2_port_lock); > > This needs to be > > static DEFINE_SPINLOCK(cpm2_port_lock); These are equivalents. #define

Re: [PATCH 3/4] [POWERPC] CPM2: implement GPIO API

2007-12-21 Thread Arnd Bergmann
On Friday 21 December 2007, Anton Vorontsov wrote: > > +static spinlock_t cpm2_port_lock = __SPIN_LOCK_UNLOCKED(cpm2_port_lock); This needs to be static DEFINE_SPINLOCK(cpm2_port_lock); I think at least lockdep doesn't work the way you do it here. > +int cpm2_init_par_io(void) > +{ > + st