Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-12-08 Thread Grant Likely
On Tue, Dec 8, 2009 at 1:48 PM, Wim Van Sebroeck wrote: > Hi Grant, > > Sorry for the delay, I need to deliver a project in a weeks time... understood. >> In actual fact, it is a single device with multiple functions, some of >> which can be used at the same time.  The driver for the device >>

Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-12-08 Thread Wim Van Sebroeck
Hi Grant, Sorry for the delay, I need to deliver a project in a weeks time... > In actual fact, it is a single device with multiple functions, some of > which can be used at the same time. The driver for the device > determines what the device instance supports and registers the > appropriate in

Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-11-12 Thread Grant Likely
On Thu, Nov 12, 2009 at 2:36 PM, Wim Van Sebroeck wrote: > Hi All, > >>> Can the WDT functionality just be merged entirely into >>> arch/powerpc/platforms/52xx/mpc52xx_gpt.c, eliminating the need for >>> this file entirely?  I think I'd rather have all the GPT "built in" >>> behaviour handled by

Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-11-12 Thread Wim Van Sebroeck
Hi All, >> Can the WDT functionality just be merged entirely into >> arch/powerpc/platforms/52xx/mpc52xx_gpt.c, eliminating the need for >> this file entirely? I think I'd rather have all the GPT "built in" >> behaviour handled by a single driver. > > I also thought about it, as it has IMHO the c

Re: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-11-11 Thread Grant Likely
On Wed, Nov 11, 2009 at 1:32 AM, Albrecht Dreß wrote: > Hi Grant: > > O.k., thanks for your comments.  If Wim doesn't have any objections to it, I > will provide a merged patch.  One consequence I forgot to mention is that we > loose the ability to build the wdt support as module, but I don't

Aw: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-11-11 Thread Albrecht Dre�
should keep the kernel config option enable/disable the wdt support, which would mask out the wdt code if disabled. Is that ok for you? Thanks, Albrecht. - Original Nachricht Von: Grant Likely An: Albrecht Dreß Datum: 10.11.2009 22:07 Betreff: Re: [PATCH 3/3] mpc52xx/wdt: W

Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-11-10 Thread Grant Likely
On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dreß wrote: > Use the MPC5200 GPT api for the WDT which drastically simplifies this file. > > Signed-off-by: Albrecht Dreß > --- > >  drivers/watchdog/mpc5200_wdt.c |  246 > +++- >  1 files changed, 65 insertions

Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-11-10 Thread Albrecht Dreß
Hi Grant: Am 10.11.09 20:59 schrieb(en) Grant Likely: On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dreß wrote: > Use the MPC5200 GPT api for the WDT which drastically simplifies this file. > > Signed-off-by: Albrecht Dreß > --- > >  drivers/watchdog/mpc5200_wdt.c |  246 +++-

Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api

2009-11-10 Thread Grant Likely
On Tue, Nov 10, 2009 at 1:26 PM, Albrecht Dreß wrote: > Hi Grant: > > Am 10.11.09 20:59 schrieb(en) Grant Likely: >> >> On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dreß >> wrote: >> > Use the MPC5200 GPT api for the WDT which drastically simplifies this >> > file. >> > >> > Signed-off-by: Albrec