Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-12 Thread Sean MacLennan
Stefan Roese wrote: > You define here one gpio node that covers both gpio controllers of the 440EP. > I suggest to use two nodes here, like: > > GPIO0: [EMAIL PROTECTED] { > compatible = "ibm,gpio-440ep"; > reg = ; >

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-11 Thread Stefan Roese
On Saturday 12 January 2008, Sean MacLennan wrote: > +++ arch/powerpc/boot/dts/warp.dts2008-01-11 15:58:03.0 -0500 > @@ -0,0 +1,234 @@ > +/* > + * Device Tree Source for PIKA Warp > + * > + * Copyright (c) 2008 PIKA Technologies > + * Sean MacLennan <[EMAIL PROTECTED]> > + * > + * Thi

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-11 Thread Sean MacLennan
Josh Boyer wrote: > On Fri, 11 Jan 2008 01:15:48 -0500 > Sean MacLennan <[EMAIL PROTECTED]> wrote: > This looks pretty darn good, minus the missing GPIO node (see comment > in patch 1). > Thanks. I have added the gpio and tested it. Cheers, Sean Signed-off-by: Sean MacLennan <[EMAIL PROTECT

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-11 Thread Josh Boyer
On Fri, 11 Jan 2008 01:15:48 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > David Gibson wrote: > > Or possibly what you actually want is: > > [EMAIL PROTECTED],0 { > > reg = <2 0 2200>; > > ... > > }; > > > That is what I want. I was missing a call to > ibm4

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-10 Thread Sean MacLennan
David Gibson wrote: > Or possibly what you actually want is: > [EMAIL PROTECTED],0 { > reg = <2 0 2200>; > ... > }; > That is what I want. I was missing a call to ibm4xx_fixup_ebc_ranges("/plb/opb/ebc"); (see updated patch3/5 to follow. Signed-off-by: Se

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-10 Thread David Gibson
On Fri, Jan 11, 2008 at 12:21:20AM -0500, Sean MacLennan wrote: > David Gibson wrote: > > On Thu, Jan 10, 2008 at 06:59:03PM -0500, Sean MacLennan wrote: > > > >> New version with recommended changes. Device types removed. FPGA > >> moved to correct bus. > >> > > > > [snip] > > > >> +

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-10 Thread Sean MacLennan
David Gibson wrote: > On Thu, Jan 10, 2008 at 06:59:03PM -0500, Sean MacLennan wrote: > >> New version with recommended changes. Device types removed. FPGA >> moved to correct bus. >> > > [snip] > >> +[EMAIL PROTECTED],0 { >> +

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-10 Thread David Gibson
On Thu, Jan 10, 2008 at 06:59:03PM -0500, Sean MacLennan wrote: > New version with recommended changes. Device types removed. FPGA > moved to correct bus. [snip] > + [EMAIL PROTECTED],0 { > + compatible = "pika,fpga"; > +

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-10 Thread Sean MacLennan
New version with recommended changes. Device types removed. FPGA moved to correct bus. Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- --- /dev/null 2005-11-20 22:22:37.0 -0500 +++ arch/powerpc/boot/dts/warp.dts 2008-01-10 13:04:49.0 -0500 @@ -0,0 +1,230 @@ +/* + * De

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-09 Thread David Gibson
On Wed, Jan 09, 2008 at 10:33:56PM -0500, Sean MacLennan wrote: > Ok, the FPGA is off the EBC, I found it in the documentation. > > Under the ebc, I notice the walnut has @n,m. What are n,m? Are they tied > to chip selects? n is the chipselect, m is the address offset within that chipselect. >

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-09 Thread Josh Boyer
On Wed, 09 Jan 2008 22:33:56 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > Ok, the FPGA is off the EBC, I found it in the documentation. > > Under the ebc, I notice the walnut has @n,m. What are n,m? Are they tied > to chip selects? chip select,offset. > The FPGA is CS2 according to the do

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-09 Thread Sean MacLennan
Ok, the FPGA is off the EBC, I found it in the documentation. Under the ebc, I notice the walnut has @n,m. What are n,m? Are they tied to chip selects? The FPGA is CS2 according to the documentation. Do I make it [EMAIL PROTECTED],0? Cheers, Sean ___

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-09 Thread Josh Boyer
On Wed, 09 Jan 2008 22:14:17 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > David Gibson wrote: > > On Wed, Jan 09, 2008 at 03:21:07PM -0500, Sean MacLennan wrote: > > > >> Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> > >> --- > >> --- /dev/null 2005-11-20 22:22:37.0 -0500

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-09 Thread Sean MacLennan
David Gibson wrote: > On Wed, Jan 09, 2008 at 03:21:07PM -0500, Sean MacLennan wrote: > >> Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> >> --- >> --- /dev/null2005-11-20 22:22:37.0 -0500 >> +++ arch/powerpc/boot/dts/warp.dts 2008-01-08 12:04:10.0 -0500 >> > >

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-09 Thread David Gibson
On Wed, Jan 09, 2008 at 03:21:07PM -0500, Sean MacLennan wrote: > Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> > --- > --- /dev/null 2005-11-20 22:22:37.0 -0500 > +++ arch/powerpc/boot/dts/warp.dts2008-01-08 12:04:10.0 -0500 [snip] > + plb { > + compatible