Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread Vitaly Bordug
On Mon, 27 Aug 2007 11:54:17 +1000 David Gibson wrote: > On Sat, Aug 25, 2007 at 01:29:54PM +0400, Vitaly Bordug wrote: > > > > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > > > > --- > > > > arch/powerpc/boot/dts/sequoia.dts | 26

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread Stefan Roese
On Monday 27 August 2007, David Gibson wrote: > On Mon, Aug 27, 2007 at 08:07:17AM +0200, Stefan Roese wrote: > [snip] > > > > I usually put device_type, compatible and reg at the top of the block, > > > to announce what the node actually is before giving all the details. > > > > > > Also, apart fr

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread David Gibson
On Mon, Aug 27, 2007 at 08:07:17AM +0200, Stefan Roese wrote: [snip] > > I usually put device_type, compatible and reg at the top of the block, > > to announce what the node actually is before giving all the details. > > > > Also, apart from the stray space in the compatible, I'm guessing that > >

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread Stefan Roese
On Monday 27 August 2007, David Gibson wrote: > On Sat, Aug 25, 2007 at 01:29:54PM +0400, Vitaly Bordug wrote: > > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > > > > --- > > > > arch/powerpc/boot/dts/sequoia.dts | 26 +

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread Stefan Roese
On Saturday 25 August 2007, Segher Boessenkool wrote: > > + compatible = "ibm, 440epx"; > > Oh, and shouldn't it be "amcc," anyway? Not sure here. It's still the PCI core used on the early 405 and 440 platforms build by IBM. If we use IBM on other core logic like UIC, EMAC etc,

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread David Gibson
On Sun, Aug 26, 2007 at 02:27:50PM +0400, Vitaly Bordug wrote: > On Sat, 25 Aug 2007 11:49:58 +0200 Segher Boessenkool wrote: [snip] > > > + compatible = "ibm, 440epx"; > > > > Stray space. And you need to say it is the PCI host, so something > > like "ibm,440epx-pci". > > > OK,

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread David Gibson
On Sat, Aug 25, 2007 at 01:29:54PM +0400, Vitaly Bordug wrote: > > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > > --- > > arch/powerpc/boot/dts/sequoia.dts | 26 ++ > 1 files changed, 26 insertions(+), 0 deletions

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread Segher Boessenkool
>>> + pci { >>> + reg = <1 eec0 40 1 ef40 >>> 40>; /* phb cfg, phb reg */ >> >> First component of reg is the unit address, so: [EMAIL PROTECTED] . >> >> "phb cfg" is how you access PCI configuration space? It wouldn't >> hurt to document that, either i

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-26 Thread Vitaly Bordug
On Sat, 25 Aug 2007 11:49:58 +0200 Segher Boessenkool wrote: > > + pci { > > + reg = <1 eec0 40 1 ef40 > > 40>; /* phb cfg, phb reg */ > > First component of reg is the unit address, so: [EMAIL PROTECTED] . > > "phb cfg" is how you access PCI configur

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-25 Thread Segher Boessenkool
> + compatible = "ibm, 440epx"; Oh, and shouldn't it be "amcc," anyway? Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/3] [POWERPC] Add pci node to sequoia dts

2007-08-25 Thread Segher Boessenkool
> + pci { > + reg = <1 eec0 40 1 ef40 40>; /* phb cfg, phb > reg */ First component of reg is the unit address, so: [EMAIL PROTECTED] . "phb cfg" is how you access PCI configuration space? It wouldn't hurt to document that, either in a little binding or