Re: [PATCH 2/2] powerpc,kexec: Speedup kexec hpte tear down

2010-05-11 Thread Michael Ellerman
On Wed, 2010-05-12 at 11:06 +1000, Michael Neuling wrote: > > > We probably only do the remove on < 1% of the hptes now. So I doubt we > > > would get a speedup since most of the time we aren't do the remove > > > anymore. > > > > It would be nice to have some actual numbers. Could you add some

Re: [PATCH 2/2] powerpc,kexec: Speedup kexec hpte tear down

2010-05-11 Thread Michael Neuling
> > We probably only do the remove on < 1% of the hptes now. So I doubt we > > would get a speedup since most of the time we aren't do the remove > > anymore. > > It would be nice to have some actual numbers. Could you add some > counters and print the results at the end? (Or don't you have any

Re: [PATCH 2/2] powerpc,kexec: Speedup kexec hpte tear down

2010-05-11 Thread Paul Mackerras
On Wed, May 12, 2010 at 10:43:08AM +1000, Michael Neuling wrote: > We probably only do the remove on < 1% of the hptes now. So I doubt we > would get a speedup since most of the time we aren't do the remove > anymore. It would be nice to have some actual numbers. Could you add some counters and

Re: [PATCH 2/2] powerpc,kexec: Speedup kexec hpte tear down

2010-05-11 Thread Michael Neuling
In message <1273624565.5738.8.ca...@concordia> you wrote: > > --=-wnrJa93KBardFtse2eHB > Content-Type: text/plain; charset="UTF-8" > Content-Transfer-Encoding: quoted-printable > > On Wed, 2010-05-12 at 09:29 +1000, Michael Neuling wrote: > >=20 > > In message <1273561463.9209.138.ca...@concord

Re: [PATCH 2/2] powerpc,kexec: Speedup kexec hpte tear down

2010-05-11 Thread Michael Ellerman
On Wed, 2010-05-12 at 09:29 +1000, Michael Neuling wrote: > > In message <1273561463.9209.138.ca...@concordia> you wrote: > > > > --=-S056dRzmrEHDBzKyyTOs > > Content-Type: text/plain; charset="UTF-8" > > Content-Transfer-Encoding: quoted-printable > > > > On Tue, 2010-05-11 at 16:28 +1000, Mich

Re: [PATCH 2/2] powerpc,kexec: Speedup kexec hpte tear down

2010-05-11 Thread Michael Neuling
In message <1273561463.9209.138.ca...@concordia> you wrote: > > --=-S056dRzmrEHDBzKyyTOs > Content-Type: text/plain; charset="UTF-8" > Content-Transfer-Encoding: quoted-printable > > On Tue, 2010-05-11 at 16:28 +1000, Michael Neuling wrote: > > Currently for kexec the PTE tear down on 1TB segme

Re: [PATCH 2/2] powerpc,kexec: Speedup kexec hpte tear down

2010-05-11 Thread Michael Ellerman
On Tue, 2010-05-11 at 16:28 +1000, Michael Neuling wrote: > Currently for kexec the PTE tear down on 1TB segment systems normally > requires 3 hcalls for each PTE removal. On a machine with 32GB of > memory it can take around a minute to remove all the PTEs. > .. > - /* TODO: Use bulk call */