Re: [PATCH 15/18] powerpc/smp: Don't expose per-cpu "cpu_state" array

2011-03-29 Thread Benjamin Herrenschmidt
On Tue, 2011-03-29 at 16:37 +1100, Michael Ellerman wrote: > Takes a cpu parameter .. > > > +void generic_set_cpu_dead(unsigned int cpu) > > +{ > > + __get_cpu_var(cpu_state) = CPU_DEAD; > > +} > > But doesn't use it. Yeah that's a bug. Fortunately it's always called on the current CPU :-) I

Re: [PATCH 15/18] powerpc/smp: Don't expose per-cpu "cpu_state" array

2011-03-28 Thread Michael Ellerman
On Tue, 2011-03-08 at 17:37 +1100, Benjamin Herrenschmidt wrote: > Instead, keep it static, expose an accessor and use that from > the PowerMac code. Avoids easy namespace collisions and will > make it easier to consolidate with other implementations. > > Signed-off-by: Benjamin Herrenschmidt > -