Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

out_8(&cpm->i2c_reg->i2mod, 0x00); - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER);/* Master mode */ + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER);/* Host mode */ I2COM_MASTER might be coming from the datasheet. Maybe we can just drop the comment? The value we write is pret

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

> > > out_8(&cpm->i2c_reg->i2mod, 0x00); > > > - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > > > + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Host mode */ > > > > I2COM_MASTER might be coming from the datasheet. > > Maybe we can just drop the comment? The value w

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

> > out_8(&cpm->i2c_reg->i2mod, 0x00); > > - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > > + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Host mode */ > > I2COM_MASTER might be coming from the datasheet. Maybe we can just drop the comment? The value we write

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

Hi Wolfram, ... > @@ -570,7 +570,7 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm) > out_8(&cpm->i2c_reg->i2brg, brg); > > out_8(&cpm->i2c_reg->i2mod, 0x00); > - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER);