Re: [PATCH 11/25] powerpc: 4xx PLB to PCI Express support

2007-12-08 Thread Benjamin Herrenschmidt
On Fri, 2007-12-07 at 08:02 +0100, Stefan Roese wrote: > > > Ah... crap ! Do you think we should put that in the boot wrapper and > > fixup the device-tree or should we put it in the PCIe code proper ? > > How about this: We change the compatible node to "plb-pciex-440spe" > (without "A" and "B

Re: [PATCH 11/25] powerpc: 4xx PLB to PCI Express support

2007-12-06 Thread Stefan Roese
On Thursday 06 December 2007, Benjamin Herrenschmidt wrote: > > > +/* Check that the core has been initied and if not, do it */ > > > +static int __init ppc4xx_pciex_check_core_init(struct device_node *np) > > > +{ > > > + static int core_init; > > > + int count = -ENODEV; > > > + > > > + if (core_

Re: [PATCH 11/25] powerpc: 4xx PLB to PCI Express support

2007-12-06 Thread Benjamin Herrenschmidt
> > +/* Check that the core has been initied and if not, do it */ > > +static int __init ppc4xx_pciex_check_core_init(struct device_node *np) > > +{ > > + static int core_init; > > + int count = -ENODEV; > > + > > + if (core_init++) > > + return 0; > > + > > +#ifdef CONFIG_44x > >

Re: [PATCH 11/25] powerpc: 4xx PLB to PCI Express support

2007-12-06 Thread Stefan Roese
On Thursday 06 December 2007, Benjamin Herrenschmidt wrote: > This adds to the previous 2 patches the support for the 4xx PCI Express > cells as found in the 440SPe revA, revB and 405EX. > > Unfortunately, due to significant differences between these, and other > interesting "features" of those pie