Re: [PATCH 11/13] ALSA: Deletion of checks before the function call "iounmap"

2016-10-26 Thread Dan Carpenter
On Wed, Oct 26, 2016 at 02:28:59PM +0200, Johannes Berg wrote: > On Wed, 2016-10-26 at 15:26 +0300, Dan Carpenter wrote: > > Someone was just mentioning in another thread that removing the check > > from iounmap() is not portable to other arches and then I remembered > > that Markus removed a bunch

Re: [PATCH 11/13] ALSA: Deletion of checks before the function call "iounmap"

2016-10-26 Thread Johannes Berg
On Wed, 2016-10-26 at 15:26 +0300, Dan Carpenter wrote: > Someone was just mentioning in another thread that removing the check > from iounmap() is not portable to other arches and then I remembered > that Markus removed a bunch of these. > > We should consider reverting this, perhaps? Can't we t

Re: [PATCH 11/13] ALSA: Deletion of checks before the function call "iounmap"

2016-10-26 Thread Dan Carpenter
Someone was just mentioning in another thread that removing the check from iounmap() is not portable to other arches and then I remembered that Markus removed a bunch of these. We should consider reverting this, perhaps? regards, dan carpenter On Sun, Jan 04, 2015 at 02:36:01PM +0100, SF Markus

Re: [PATCH 11/13] ALSA: Deletion of checks before the function call "iounmap"

2015-01-05 Thread Dan Carpenter
On Sun, Jan 04, 2015 at 02:36:01PM +0100, SF Markus Elfring wrote: > /* unmap PCI memory space, mapped during device init. */ > - for (idx = 0; idx < HPI_MAX_ADAPTER_MEM_SPACES; idx++) { > - if (pci.ap_mem_base[idx]) > - iounmap(pci.ap_mem_base[idx]); > -