Re: [PATCH 1/4] 44x/fsp2: add fsp2 headers

2017-11-27 Thread Benjamin Herrenschmidt
On Mon, 2017-11-27 at 15:58 +1100, Alistair Popple wrote: > Hi Ivan, > > Does it make sense to have these in a seperate include file? From what I could > see these defines were only used in fsp2.c so you could just put them directly > in there. Or at least have an fsp2.h next to fsp2.c rather tha

Re: [PATCH 1/4] 44x/fsp2: add fsp2 headers

2017-11-26 Thread Alistair Popple
Hi Ivan, Does it make sense to have these in a seperate include file? From what I could see these defines were only used in fsp2.c so you could just put them directly in there. - Alistair On Thursday, 2 November 2017 4:07:03 PM AEDT Ivan Mikhaylov wrote: > * add cmu, plbX, l2 register definition