Re: [PATCH 1/3] powerpc/smp: Parse ibm,thread-groups with multiple properties

On Wed, Dec 09, 2020 at 02:05:41PM +0530, Srikar Dronamraju wrote: > * Gautham R Shenoy [2020-12-08 22:55:40]: > > > > > > > NIT: > > > tglx mentions in one of his recent comments to try keep a reverse fir tree > > > ordering of variables where possible. > > > > I suppose you mean moving the lo

Re: [PATCH 1/3] powerpc/smp: Parse ibm,thread-groups with multiple properties

* Gautham R Shenoy [2020-12-08 22:55:40]: > > > > NIT: > > tglx mentions in one of his recent comments to try keep a reverse fir tree > > ordering of variables where possible. > > I suppose you mean moving the longer local variable declarations to to > the top and shorter ones to the bottom. Th

Re: [PATCH 1/3] powerpc/smp: Parse ibm, thread-groups with multiple properties

Gautham R Shenoy writes: > Hello Srikar, > > Thanks for taking a look at the patch. > > On Mon, Dec 07, 2020 at 05:40:42PM +0530, Srikar Dronamraju wrote: >> * Gautham R. Shenoy [2020-12-04 10:18:45]: >> >> > From: "Gautham R. Shenoy" >> >> >> >> > >> > static int parse_thread_groups(struc

Re: [PATCH 1/3] powerpc/smp: Parse ibm,thread-groups with multiple properties

Hello Srikar, Thanks for taking a look at the patch. On Mon, Dec 07, 2020 at 05:40:42PM +0530, Srikar Dronamraju wrote: > * Gautham R. Shenoy [2020-12-04 10:18:45]: > > > From: "Gautham R. Shenoy" > > > > > > > static int parse_thread_groups(struct device_node *dn, > > -

Re: [PATCH 1/3] powerpc/smp: Parse ibm,thread-groups with multiple properties

* Gautham R. Shenoy [2020-12-04 10:18:45]: > From: "Gautham R. Shenoy" > > static int parse_thread_groups(struct device_node *dn, > -struct thread_groups *tg, > -unsigned int property) > +struct thread_group