Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-19 Thread Anton Vorontsov
On Tue, Aug 19, 2008 at 11:26:28AM +0200, Laurent Pinchart wrote: [...] > > I didn't say "SOC-specific". I said "SOC-model specific", which > > means that the driver would be not portable even across QE chips > > (i.e. MPC8323 vs. MPC8360, you can assume that the "CLK12" function > > is having same

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-19 Thread Laurent Pinchart
On Monday 18 August 2008, Anton Vorontsov wrote: > On Mon, Aug 18, 2008 at 04:44:36PM +0200, Laurent Pinchart wrote: > > On Monday 18 August 2008, Anton Vorontsov wrote: > > > On Mon, Aug 18, 2008 at 03:58:46PM +0200, Laurent Pinchart wrote: > > > [...] > > > > > Not exactly. But you can do this wa

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-18 Thread Anton Vorontsov
On Mon, Aug 18, 2008 at 04:44:36PM +0200, Laurent Pinchart wrote: > On Monday 18 August 2008, Anton Vorontsov wrote: > > On Mon, Aug 18, 2008 at 03:58:46PM +0200, Laurent Pinchart wrote: > > [...] > > > > Not exactly. But you can do this way, if you need to preserve > > > > a direction. What I did

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-18 Thread Laurent Pinchart
On Monday 18 August 2008, Anton Vorontsov wrote: > On Mon, Aug 18, 2008 at 03:58:46PM +0200, Laurent Pinchart wrote: > [...] > > > Not exactly. But you can do this way, if you need to preserve > > > a direction. What I did is a bit different though. > > > > > > qe_gpio_set_dedicated() actually jus

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-18 Thread Anton Vorontsov
On Mon, Aug 18, 2008 at 03:58:46PM +0200, Laurent Pinchart wrote: [...] > > Not exactly. But you can do this way, if you need to preserve > > a direction. What I did is a bit different though. > > > > qe_gpio_set_dedicated() actually just restores a mode that > > firmware had set up, including dir

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-18 Thread Laurent Pinchart
On Thursday 14 August 2008, Anton Vorontsov wrote: > On Thu, Aug 14, 2008 at 04:45:52PM +0200, Laurent Pinchart wrote: > > On Thursday 14 August 2008, Anton Vorontsov wrote: > > > On Thu, Aug 14, 2008 at 04:04:18PM +0200, Laurent Pinchart wrote: > > > > On Friday 08 August 2008, Anton Vorontsov wro

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-14 Thread Anton Vorontsov
On Thu, Aug 14, 2008 at 04:45:52PM +0200, Laurent Pinchart wrote: > On Thursday 14 August 2008, Anton Vorontsov wrote: > > On Thu, Aug 14, 2008 at 04:04:18PM +0200, Laurent Pinchart wrote: > > > On Friday 08 August 2008, Anton Vorontsov wrote: > > > > We'll need this function to write platform-spec

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-14 Thread Laurent Pinchart
On Thursday 14 August 2008, Anton Vorontsov wrote: > On Thu, Aug 14, 2008 at 04:04:18PM +0200, Laurent Pinchart wrote: > > On Friday 08 August 2008, Anton Vorontsov wrote: > > > We'll need this function to write platform-specific hooks to deal > > > with pin's dedicated functions. Quite obviously t

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-14 Thread Anton Vorontsov
On Thu, Aug 14, 2008 at 04:04:18PM +0200, Laurent Pinchart wrote: > On Friday 08 August 2008, Anton Vorontsov wrote: > > We'll need this function to write platform-specific hooks to deal > > with pin's dedicated functions. Quite obviously this will work only > > for the platforms with 1-to-1 GPIO t

Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-14 Thread Laurent Pinchart
On Friday 08 August 2008, Anton Vorontsov wrote: > We'll need this function to write platform-specific hooks to deal > with pin's dedicated functions. Quite obviously this will work only > for the platforms with 1-to-1 GPIO to PIN mapping. > > This is stopgap solution till we think out and impleme