Re: [PATCH 1/3] cell: fix undefined reference to mmio_nvram_init

2007-12-05 Thread Ishizaki Kou
Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Tuesday 04 December 2007, Ishizaki Kou wrote: > > > > +#ifdef CONFIG_MMIO_NVRAM > > mmio_nvram_init(); > > +#endif > > } > > The patch is technically correct, but the preferred way of doing this is > to define a conditional inline function in the

Re: [PATCH 1/3] cell: fix undefined reference to mmio_nvram_init

2007-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2007, Ishizaki Kou wrote: > > +#ifdef CONFIG_MMIO_NVRAM > mmio_nvram_init(); > +#endif >  } The patch is technically correct, but the preferred way of doing this is to define a conditional inline function in the header, like: #ifdef CONFIG_MMIO_NVRAM extern int mmi