Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-16 Thread Ryan Grimm
On 01/15/2015 11:15 PM, Ian Munsie wrote: Hi Ryan, Excerpts from Ryan Grimm's message of 2015-01-16 09:27:15 +1100: reset_image_select identifies whether a PERST will cause the image to be s/reset_image_select/load_image_on_perst/ Ah, thanks, fixed. +What: /sys/class/cxl//load_

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-15 Thread Ian Munsie
Hi Ryan, Excerpts from Ryan Grimm's message of 2015-01-16 09:27:15 +1100: > reset_image_select identifies whether a PERST will cause the image to be s/reset_image_select/load_image_on_perst/ > +What: /sys/class/cxl//load_image_on_perst > +Date: December 2014 > +Contact:

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-15 Thread Ryan Grimm
Ian, Thanks for reviewing! On 01/14/2015 11:41 PM, Ian Munsie wrote: Excerpts from Ryan Grimm's message of 2015-01-15 13:56:39 +1100: Add reset_loads_image and reset_image_select to sysfs. reset_image_select identifies which image will be loaded to the card on the next PERST. Valid entries a

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-14 Thread Ian Munsie
Excerpts from Michael Ellerman's message of 2015-01-15 16:07:17 +1100: > > Of the two names I'd probably go with reset_image_select. > > Three words, all can be verbs, two can be nouns, it's not too clear. > > Maybe "load_image_on_perst" ? Works for me :) Cheers, -Ian _

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-14 Thread Michael Ellerman
On Thu, 2015-01-15 at 15:41 +1100, Ian Munsie wrote: > Excerpts from Ryan Grimm's message of 2015-01-15 13:56:39 +1100: > > Add reset_loads_image and reset_image_select to sysfs. > > > > reset_image_select identifies which image will be loaded to the card on the > > next PERST. Valid entries are:

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-14 Thread Ian Munsie
> While I think of it - if we change this on boot we should also change > reset_image_select to match the currently loaded image. e.g. if > reset_loads_image has defaulted to off and reset_image_select has > defaulted to factory, but the user image has been loaded - that way we > avoid unexpectedly

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-14 Thread Ian Munsie
Excerpts from Ian Munsie's message of 2015-01-15 15:41:24 +1100: > At the moment we don't set it at boot - we just go with whatever the > card is already set to do. I'm thinking it might be a good idea to > always set this bit on boot so the only time it's disabled is if a user > has explicitly gon

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-14 Thread Ian Munsie
Excerpts from Ryan Grimm's message of 2015-01-15 13:56:39 +1100: > Add reset_loads_image and reset_image_select to sysfs. > > reset_image_select identifies which image will be loaded to the card on the > next PERST. Valid entries are: "user" and "factory". > > reset_loads_image defines functiona