Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2023-01-17 Thread Athira Rajeev
> On 17-Jan-2023, at 3:30 AM, Ian Rogers wrote: > > On Mon, Jan 16, 2023 at 4:00 AM Athira Rajeev > wrote: >> >> >> >>> On 16-Jan-2023, at 11:47 AM, Ian Rogers wrote: >>> >>> On Sun, Jan 15, 2023 at 9:03 PM Athira Rajeev >>> wrote: > On 28-Sep-2022, at 10:24 AM, At

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2023-01-16 Thread Ian Rogers
On Mon, Jan 16, 2023 at 4:00 AM Athira Rajeev wrote: > > > > > On 16-Jan-2023, at 11:47 AM, Ian Rogers wrote: > > > > On Sun, Jan 15, 2023 at 9:03 PM Athira Rajeev > > wrote: > >> > >> > >> > >>> On 28-Sep-2022, at 10:24 AM, Athira Rajeev > >>> wrote: > >>> > >>> Hi All, > >>> > >>> Looking fo

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2023-01-16 Thread Athira Rajeev
> On 16-Jan-2023, at 11:47 AM, Ian Rogers wrote: > > On Sun, Jan 15, 2023 at 9:03 PM Athira Rajeev > wrote: >> >> >> >>> On 28-Sep-2022, at 10:24 AM, Athira Rajeev >>> wrote: >>> >>> Hi All, >>> >>> Looking for what direction we can take here. >>> Do we want to change all tests in tool

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2023-01-15 Thread Ian Rogers
On Sun, Jan 15, 2023 at 9:03 PM Athira Rajeev wrote: > > > > > On 28-Sep-2022, at 10:24 AM, Athira Rajeev > > wrote: > > > > Hi All, > > > > Looking for what direction we can take here. > > Do we want to change all tests in tools/perf/tests/shell except > > test_intel_pt.sh to use "bash" or go

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2023-01-15 Thread Athira Rajeev
> On 28-Sep-2022, at 10:24 AM, Athira Rajeev > wrote: > > Hi All, > > Looking for what direction we can take here. > Do we want to change all tests in tools/perf/tests/shell except > test_intel_pt.sh to use "bash" or go with > the approach in the patch ? Please share your comments > > Than

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2022-09-27 Thread Athira Rajeev
Hi All, Looking for what direction we can take here. Do we want to change all tests in tools/perf/tests/shell except test_intel_pt.sh to use "bash" or go with the approach in the patch ? Please share your comments Thanks Athira > On 23-Sep-2022, at 11:54 AM, Adrian Hunter wrote: > > On 22/09/

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2022-09-22 Thread Adrian Hunter
On 22/09/22 22:15, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 21, 2022 at 10:38:38PM +0530, Athira Rajeev escreveu: >> The perf test named “build id cache operations” skips with below >> error on some distros: > > I wonder if we shouldn't instead state that bash is needed? > > ⬢[acme@toolbox p

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2022-09-22 Thread Ian Rogers
On Thu, Sep 22, 2022 at 12:15 PM Arnaldo Carvalho de Melo wrote: > > Em Wed, Sep 21, 2022 at 10:38:38PM +0530, Athira Rajeev escreveu: > > The perf test named “build id cache operations” skips with below > > error on some distros: > > I wonder if we shouldn't instead state that bash is needed? > >

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2022-09-22 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 21, 2022 at 10:38:38PM +0530, Athira Rajeev escreveu: > The perf test named “build id cache operations” skips with below > error on some distros: I wonder if we shouldn't instead state that bash is needed? ⬢[acme@toolbox perf-urgent]$ head -1 tools/perf/tests/shell/*.sh | grep ^# #!/b