Re: [PATCH 1/2] powerpc: pci config cleanup [rev2]

2008-07-15 Thread Kumar Gala
On Jun 26, 2008, at 12:07 PM, John Rigby wrote: Choosing PCI or not at config time is allowed on some platforms via an if expression in arch/powerpc/Kconfig. To add a new platform with PCI support selectable at config time, you must change the if expression. This patch makes this easier by cha

Re: [PATCH 1/2] powerpc: pci config cleanup [rev2]

2008-06-28 Thread Grant Likely
On Thu, Jun 26, 2008 at 11:07:56AM -0600, John Rigby wrote: > Choosing PCI or not at config time is allowed on some > platforms via an if expression in arch/powerpc/Kconfig. > To add a new platform with PCI support selectable at > config time, you must change the if expression. This > patch makes

Re: [PATCH 1/2] powerpc: pci config cleanup

2008-06-25 Thread John Rigby
Thanks Michael, your explanation makes things make more sense. I was just a half intelligent monkey trying to replicate the existing logic. I think your explanation also answers Ben's question also. On Wed, Jun 25, 2008 at 6:53 PM, Michael Ellerman <[EMAIL PROTECTED]> wrote: > On Wed, 2008-06-25

Re: [PATCH 1/2] powerpc: pci config cleanup

2008-06-25 Thread Michael Ellerman
On Wed, 2008-06-25 at 14:19 -0600, John Rigby wrote: > change > bool "PCI support" if > to > bool "PCI support" if PPC_HAS_PCI > > and add select PPC_HAS_PCI to all the config nodes that > were previously in the PCI if expression > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconf

Re: [PATCH 1/2] powerpc: pci config cleanup

2008-06-25 Thread Benjamin Herrenschmidt
On Wed, 2008-06-25 at 14:19 -0600, John Rigby wrote: > change > bool "PCI support" if > to > bool "PCI support" if PPC_HAS_PCI > > and add select PPC_HAS_PCI to all the config nodes that > were previously in the PCI if expression > > Signed-off-by: John Rigby <[EMAIL PROTECTED]> > --- >