Re: [PATCH 1/2] Make setjmp/longjmp code generic

2008-01-17 Thread Michael Ellerman
On Thu, 2008-01-17 at 06:45 -0600, Josh Boyer wrote: > On Thu, 17 Jan 2008 16:36:49 +1100 > Michael Neuling <[EMAIL PROTECTED]> wrote: > > In message <[EMAIL PROTECTED]> you wrote: > > > Hi, > > > > > > On Thu, Jan 17, 2008 at 03:45:42PM +1100, Michael Neuling wrote: > > > > > > > Index: linux-2.

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2008-01-17 Thread Josh Boyer
On Thu, 17 Jan 2008 16:36:49 +1100 Michael Neuling <[EMAIL PROTECTED]> wrote: > > > In message <[EMAIL PROTECTED]> you wrote: > > Hi, > > > > On Thu, Jan 17, 2008 at 03:45:42PM +1100, Michael Neuling wrote: > > > > > Index: linux-2.6-ozlabs/include/asm-powerpc/setjmp.h > > > ==

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2008-01-16 Thread Stephen Rothwell
On Thu, 17 Jan 2008 15:45:42 +1100 Michael Neuling <[EMAIL PROTECTED]> wrote: > > +++ linux-2.6-ozlabs/arch/powerpc/kernel/misc.S > @@ -8,6 +8,8 @@ > * Adapted for iSeries by Mike Corrigan ([EMAIL PROTECTED]) > * PPC64 updates by Dave Engebretsen ([EMAIL PROTECTED]) > * > + * setjmp/longjmp a

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2008-01-16 Thread Stephen Rothwell
On Thu, 17 Jan 2008 16:36:49 +1100 Michael Neuling <[EMAIL PROTECTED]> wrote: > > > > > Should the above be inside #ifdef __KERNEL__? > > Yep... _and_ it's 2008 now! I think that if you don't list the file for exporting to user mode (in the Kbuild file), then you shouldn't need the __KERNEL__ pr

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2008-01-16 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote: > Hi, > > On Thu, Jan 17, 2008 at 03:45:42PM +1100, Michael Neuling wrote: > > > Index: linux-2.6-ozlabs/include/asm-powerpc/setjmp.h > > === > > --- /dev/null > > +++ linux-2.6-ozlabs/incl

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2008-01-16 Thread Olof Johansson
Hi, On Thu, Jan 17, 2008 at 03:45:42PM +1100, Michael Neuling wrote: > Index: linux-2.6-ozlabs/include/asm-powerpc/setjmp.h > === > --- /dev/null > +++ linux-2.6-ozlabs/include/asm-powerpc/setjmp.h > @@ -0,0 +1,18 @@ > +/* > + * Copy

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2007-12-12 Thread Michael Neuling
> > arch/powerpc/xmon/setjmp.S| 135 > > -- > > +#ifdef CONFIG_XMON > > +/* > > + * Grab the register values as they are now. > > + * This won't do a particularily good job because we really > > + * want our caller's caller's registers, and our cal

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2007-12-12 Thread Michael Ellerman
On Wed, 2007-12-12 at 16:45 +1100, Michael Neuling wrote: > This makes the setjmp/longjmp code used by xmon, generically available > to other code. It also removes the requirement for debugger hooks to > be only called on 0x300 (data storage) exception. > > Signed-off-by: Michael Neuling <[EMAIL

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2007-12-12 Thread Michael Neuling
> On Wed, 2007-12-12 at 20:37 +1100, Stephen Rothwell wrote: > > On Wed, 12 Dec 2007 19:06:54 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED] hing.org> wrote: > > > > > > Time to introduce a merged misc.S ? :-) > > > > We already have one ... > > Hah ! I should have looked :-) Me too! :-) Sorry

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2007-12-12 Thread Benjamin Herrenschmidt
On Wed, 2007-12-12 at 20:37 +1100, Stephen Rothwell wrote: > On Wed, 12 Dec 2007 19:06:54 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> > wrote: > > > > Time to introduce a merged misc.S ? :-) > > We already have one ... Hah ! I should have looked :-) Ben.

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2007-12-12 Thread Stephen Rothwell
On Wed, 12 Dec 2007 19:06:54 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > Time to introduce a merged misc.S ? :-) We already have one ... -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpDFBPRg7zUg.pgp Description: PGP signat

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2007-12-12 Thread Benjamin Herrenschmidt
On Wed, 2007-12-12 at 01:59 -0600, Kumar Gala wrote: > On Dec 11, 2007, at 11:45 PM, Michael Neuling wrote: > > > This makes the setjmp/longjmp code used by xmon, generically available > > to other code. It also removes the requirement for debugger hooks to > > be only called on 0x300 (data stor

Re: [PATCH 1/2] Make setjmp/longjmp code generic

2007-12-12 Thread Kumar Gala
On Dec 11, 2007, at 11:45 PM, Michael Neuling wrote: > This makes the setjmp/longjmp code used by xmon, generically available > to other code. It also removes the requirement for debugger hooks to > be only called on 0x300 (data storage) exception. > > Signed-off-by: Michael Neuling <[EMAIL PROT