Re: [PATCH 1/1] pseries/hotplug-memory.c: Change rc variable to bool

2019-08-02 Thread Leonardo Bras
On Fri, 2019-08-02 at 09:23 +0200, David Hildenbrand wrote: > subtle changes in a "Change rc variable to bool" > patch should be avoided. You are right. If it was a valid change, I should give it a patch for itself. I will keep that in mind next time. Thanks for helping! signature.asc Descript

Re: [PATCH 1/1] pseries/hotplug-memory.c: Change rc variable to bool

2019-08-02 Thread David Hildenbrand
On 02.08.19 09:18, David Hildenbrand wrote: > On 02.08.19 01:10, Leonardo Bras wrote: >> Changes the return variable to bool (as the return value) and >> avoids doing a ternary operation before returning. >> >> Also, since rc will always be true, there is no need to do >> rc &= bool, as (true && X)

Re: [PATCH 1/1] pseries/hotplug-memory.c: Change rc variable to bool

2019-08-02 Thread David Hildenbrand
On 02.08.19 01:10, Leonardo Bras wrote: > Changes the return variable to bool (as the return value) and > avoids doing a ternary operation before returning. > > Also, since rc will always be true, there is no need to do > rc &= bool, as (true && X) will result in X. > > Signed-off-by: Leonardo Br