On Mon, Nov 18, 2019 at 7:29 PM Andrew Donnellan wrote:
>
> On 19/11/19 1:48 pm, Alastair D'Silva wrote:
> > On Tue, 2019-11-19 at 10:47 +1100, Andrew Donnellan wrote:
> >> On 15/11/19 3:35 am, Dan Williams wrote:
> Have you discussed with the directory owner if it's ok to split
> the
>
On 19/11/19 1:48 pm, Alastair D'Silva wrote:
On Tue, 2019-11-19 at 10:47 +1100, Andrew Donnellan wrote:
On 15/11/19 3:35 am, Dan Williams wrote:
Have you discussed with the directory owner if it's ok to split
the
driver over several files?
My thought is to establish drivers/opencapi/ and move
On Tue, 2019-11-19 at 10:47 +1100, Andrew Donnellan wrote:
> On 15/11/19 3:35 am, Dan Williams wrote:
> > > Have you discussed with the directory owner if it's ok to split
> > > the
> > > driver over several files?
> >
> > My thought is to establish drivers/opencapi/ and move this and the
> > exis
On Mon, Nov 18, 2019 at 3:48 PM Andrew Donnellan wrote:
>
> On 15/11/19 3:35 am, Dan Williams wrote:
> >> Have you discussed with the directory owner if it's ok to split the
> >> driver over several files?
> >
> > My thought is to establish drivers/opencapi/ and move this and the
> > existing driv
On 15/11/19 3:35 am, Dan Williams wrote:
Have you discussed with the directory owner if it's ok to split the
driver over several files?
My thought is to establish drivers/opencapi/ and move this and the
existing drivers/misc/ocxl/ bits there.
Is there any other justification for this we can t
On Thu, 2019-11-14 at 14:41 +0100, Frederic Barrat wrote:
> Hi Alastair,
>
> The patch is huge and could/should probably be split in smaller
> pieces
> to ease the review. However, having sinned on that same topic in the
> past, I made a first pass anyway. I haven't covered everything but
> trie
Some quick feedback on your intro concerns...
On Thu, Nov 14, 2019 at 5:41 AM Frederic Barrat wrote:
>
> Hi Alastair,
>
> The patch is huge and could/should probably be split in smaller pieces
Yeah, it's a must. Split the minimum viable infrastructure by topic
and then follow on with per-feature
Hi Alastair,
The patch is huge and could/should probably be split in smaller pieces
to ease the review. However, having sinned on that same topic in the
past, I made a first pass anyway. I haven't covered everything but tried
to focus on the general setup of the driver for now.
Since the patch
On Mon, Nov 11, 2019 at 9:37 PM Dan Williams wrote:
>
> On Mon, Nov 11, 2019 at 3:34 AM Aneesh Kumar K.V
> wrote:
> >
> > "Alastair D'Silva" writes:
> >
> > > From: Alastair D'Silva
> > >
> > > This driver exposes LPC memory on OpenCAPI SCM cards
> > > as an NVDIMM, allowing the existing nvram
On Mon, Nov 11, 2019 at 3:34 AM Aneesh Kumar K.V
wrote:
>
> "Alastair D'Silva" writes:
>
> > From: Alastair D'Silva
> >
> > This driver exposes LPC memory on OpenCAPI SCM cards
> > as an NVDIMM, allowing the existing nvram infrastructure
> > to be used.
> >
> > Signed-off-by: Alastair D'Silva
>
"Alastair D'Silva" writes:
> From: Alastair D'Silva
>
> This driver exposes LPC memory on OpenCAPI SCM cards
> as an NVDIMM, allowing the existing nvram infrastructure
> to be used.
>
> Signed-off-by: Alastair D'Silva
> ---
> drivers/nvdimm/Kconfig | 17 +
> drivers/nvdimm/Makefi
Hi Alastair,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing]
[cannot apply to v5.4-rc5 next-20191025]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' o
Hi Alastair,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing]
[cannot apply to v5.4-rc5 next-20191025]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' o
13 matches
Mail list logo