Re: [PATCH 05/14] powerpc/eeh: Defer printing stack trace

2019-09-16 Thread Oliver O'Halloran
On Tue, Sep 17, 2019 at 1:35 PM Sam Bobroff wrote: > > On Tue, Sep 17, 2019 at 11:45:14AM +1000, Oliver O'Halloran wrote: > > > > Two reasons: > > > > 1) the eeh_event structures are allocated with GFP_ATOMIC since > > eeh_dev_check_failure() can be called from any context. Minimising the > > numb

Re: [PATCH 05/14] powerpc/eeh: Defer printing stack trace

2019-09-16 Thread Sam Bobroff
On Tue, Sep 17, 2019 at 11:45:14AM +1000, Oliver O'Halloran wrote: > On Tue, Sep 17, 2019 at 11:04 AM Sam Bobroff wrote: > > > > On Tue, Sep 03, 2019 at 08:15:56PM +1000, Oliver O'Halloran wrote: > > > Currently we print a stack trace in the event handler to help with > > > debugging EEH issues. I

Re: [PATCH 05/14] powerpc/eeh: Defer printing stack trace

2019-09-16 Thread Oliver O'Halloran
On Tue, Sep 17, 2019 at 11:04 AM Sam Bobroff wrote: > > On Tue, Sep 03, 2019 at 08:15:56PM +1000, Oliver O'Halloran wrote: > > Currently we print a stack trace in the event handler to help with > > debugging EEH issues. In the case of suprise hot-unplug this is unneeded, > > so we want to prevent

Re: [PATCH 05/14] powerpc/eeh: Defer printing stack trace

2019-09-16 Thread Sam Bobroff
On Tue, Sep 03, 2019 at 08:15:56PM +1000, Oliver O'Halloran wrote: > Currently we print a stack trace in the event handler to help with > debugging EEH issues. In the case of suprise hot-unplug this is unneeded, > so we want to prevent printing the stack trace unless we know it's due to > an actual