Re: [PATCH 04/39] arch/powerpc: Update WARN uses

2010-11-01 Thread Michael Ellerman
On Mon, 2010-11-01 at 18:50 -0700, Joe Perches wrote: > On Tue, 2010-11-02 at 11:26 +1100, Michael Ellerman wrote: > > On Mon, 2010-11-01 at 07:41 -0700, Joe Perches wrote: > > > Pretty much. Format coalescing is generally preferred for grep. > > Really? Grep doesn't work anyway because you have f

Re: [PATCH 04/39] arch/powerpc: Update WARN uses

2010-11-01 Thread Joe Perches
On Tue, 2010-11-02 at 11:26 +1100, Michael Ellerman wrote: > On Mon, 2010-11-01 at 07:41 -0700, Joe Perches wrote: > > Pretty much. Format coalescing is generally preferred for grep. > Really? Grep doesn't work anyway because you have format specifiers, and > although you can try and guess them ..

Re: [PATCH 04/39] arch/powerpc: Update WARN uses

2010-11-01 Thread Michael Ellerman
On Mon, 2010-11-01 at 07:41 -0700, Joe Perches wrote: > On Mon, 2010-11-01 at 22:02 +1100, Michael Ellerman wrote: > > On Sat, 2010-10-30 at 14:08 -0700, Joe Perches wrote: > > > Coalesce long formats. > > > Align arguments. > > > Add missing newlines. > > > > > > Signed-off-by: Joe Perches > > >

Re: [PATCH 04/39] arch/powerpc: Update WARN uses

2010-11-01 Thread Joe Perches
On Mon, 2010-11-01 at 22:02 +1100, Michael Ellerman wrote: > On Sat, 2010-10-30 at 14:08 -0700, Joe Perches wrote: > > Coalesce long formats. > > Align arguments. > > Add missing newlines. > > > > Signed-off-by: Joe Perches > > --- > > arch/powerpc/kernel/hw_breakpoint.c |4 ++-- > > 1 files

Re: [PATCH 04/39] arch/powerpc: Update WARN uses

2010-11-01 Thread Michael Ellerman
On Sat, 2010-10-30 at 14:08 -0700, Joe Perches wrote: > Coalesce long formats. > Align arguments. > Add missing newlines. > > Signed-off-by: Joe Perches > --- > arch/powerpc/kernel/hw_breakpoint.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kern