Re: [PATCH 04/12] mm: Allow compound zone device pages

2024-09-22 Thread Dan Williams
Alistair Popple wrote: > Zone device pages are used to represent various type of device memory > managed by device drivers. Currently compound zone device pages are > not supported. This is because MEMORY_DEVICE_FS_DAX pages are the only > user of higher order zone device pages and have their own p

Re: [PATCH 04/12] mm: Allow compound zone device pages

2024-09-12 Thread kernel test robot
Hi Alistair, kernel test robot noticed the following build errors: [auto build test ERROR on 6f1833b8208c3b9e59eff10792667b6639365146] url: https://github.com/intel-lab-lkp/linux/commits/Alistair-Popple/mm-gup-c-Remove-redundant-check-for-PCI-P2PDMA-page/20240910-121806 base: 6f1833b8208c3

Re: [PATCH 04/12] mm: Allow compound zone device pages

2024-09-12 Thread kernel test robot
Hi Alistair, kernel test robot noticed the following build errors: [auto build test ERROR on 6f1833b8208c3b9e59eff10792667b6639365146] url: https://github.com/intel-lab-lkp/linux/commits/Alistair-Popple/mm-gup-c-Remove-redundant-check-for-PCI-P2PDMA-page/20240910-121806 base: 6f1833b8208c3

Re: [PATCH 04/12] mm: Allow compound zone device pages

2024-09-10 Thread Matthew Wilcox
On Tue, Sep 10, 2024 at 04:57:41PM +1000, Alistair Popple wrote: > > Matthew Wilcox writes: > > > On Tue, Sep 10, 2024 at 02:14:29PM +1000, Alistair Popple wrote: > >> @@ -337,6 +341,7 @@ struct folio { > >>/* private: */ > >>}; > >>/* public: */ > >> +

Re: [PATCH 04/12] mm: Allow compound zone device pages

2024-09-10 Thread Alistair Popple
Matthew Wilcox writes: > On Tue, Sep 10, 2024 at 02:14:29PM +1000, Alistair Popple wrote: >> @@ -337,6 +341,7 @@ struct folio { >> /* private: */ >> }; >> /* public: */ >> +struct dev_pagemap *pgmap; > > Shouldn't that be indented by on

Re: [PATCH 04/12] mm: Allow compound zone device pages

2024-09-09 Thread Matthew Wilcox
On Tue, Sep 10, 2024 at 02:14:29PM +1000, Alistair Popple wrote: > @@ -337,6 +341,7 @@ struct folio { > /* private: */ > }; > /* public: */ > + struct dev_pagemap *pgmap; Shouldn't that be indented by one more tab stop? And for ease of