Re: [PATCH 03/12] fs_enet: Add FEC TX Alignment workaround for MPC5121.

2009-05-07 Thread John Rigby
I was having deja-vu with this and realized that I have fixed at least some of the objections to this patch. Wolfgang you may want to look at the patch in my 5121 git tree here: http://git.denx.de/?p=linux-mpc512x.git;a=commit;h=2950be3be42af7449941c3340998c27ef918f10f It does runtime tx packet

Re: [PATCH 03/12] fs_enet: Add FEC TX Alignment workaround for MPC5121.

2009-05-06 Thread Grant Likely
On Wed, May 6, 2009 at 4:12 PM, Wolfgang Denk wrote: > Dear Grant Likely, > > In message you > wrote: >> >> > The FEC on 5121 has problems with misaligned tx buffers. >> > The RM says any alignment is ok but empirical results >> > show that packet buffers ending in 0x1E will sometimes >> > hang

Re: [PATCH 03/12] fs_enet: Add FEC TX Alignment workaround for MPC5121.

2009-05-06 Thread Wolfgang Denk
Dear Grant Likely, In message you wrote: > > > The FEC on 5121 has problems with misaligned tx buffers. > > The RM says any alignment is ok but empirical results > > show that packet buffers ending in 0x1E will sometimes > > hang the FEC. Other bad alignment does not hang but will > > cause sile

Re: [PATCH 03/12] fs_enet: Add FEC TX Alignment workaround for MPC5121.

2009-05-06 Thread Grant Likely
On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk wrote: > From: John Rigby > > The FEC on 5121 has problems with misaligned tx buffers. > The RM says any alignment is ok but empirical results > show that packet buffers ending in 0x1E will sometimes > hang the FEC.  Other bad alignment does not hang