Re: [PATCH 01/26] KVM: PPC: Introduce shared page

2010-06-29 Thread Avi Kivity
On 06/29/2010 12:54 PM, Alexander Graf wrote: Code repeats 3x. Share please. Looking at this again, I could combine the 3 lines of init code into 3 lines of code that do a generic function call and then error checking. And I could convert the one free_page line with one function call th

Re: [PATCH 01/26] KVM: PPC: Introduce shared page

2010-06-29 Thread Alexander Graf
Avi Kivity wrote: > On 06/26/2010 02:24 AM, Alexander Graf wrote: >> For transparent variable sharing between the hypervisor and guest, I >> introduce >> a shared page. This shared page will contain all the registers the >> guest can >> read and write safely without exiting guest context. >> >> Thi

Re: [PATCH 01/26] KVM: PPC: Introduce shared page

2010-06-27 Thread Avi Kivity
On 06/26/2010 02:24 AM, Alexander Graf wrote: For transparent variable sharing between the hypervisor and guest, I introduce a shared page. This shared page will contain all the registers the guest can read and write safely without exiting guest context. This patch only implements the stubs requ