Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

2024-06-30 Thread Shrikanth Hegde
On 6/25/24 2:54 AM, Thomas Gleixner wrote: > On Tue, Jun 25 2024 at 00:41, Shrikanth Hegde wrote: >> On 6/24/24 1:44 AM, Thomas Gleixner wrote: >>> Right. So changing it not to online a thread when the full core is >>> offline should not really break stuff. >>> >>> OTH, the mechanism to figure t

Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

2024-06-24 Thread Thomas Gleixner
On Tue, Jun 25 2024 at 00:41, Shrikanth Hegde wrote: > On 6/24/24 1:44 AM, Thomas Gleixner wrote: >> Right. So changing it not to online a thread when the full core is >> offline should not really break stuff. >> >> OTH, the mechanism to figure that out on x86 is definitely different and >> more c

Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

2024-06-24 Thread Shrikanth Hegde
On 6/24/24 1:44 AM, Thomas Gleixner wrote: > Michael! > > On Thu, Jun 13 2024 at 21:34, Michael Ellerman wrote: >> IIUIC the regression was in the ppc64_cpu userspace tool, which switched >> to using the new kernel interface without taking into account the way it >> behaves. >> >> Or are you sa

Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

2024-06-23 Thread Thomas Gleixner
Michael! On Thu, Jun 13 2024 at 21:34, Michael Ellerman wrote: > IIUIC the regression was in the ppc64_cpu userspace tool, which switched > to using the new kernel interface without taking into account the way it > behaves. > > Or are you saying the kernel behaviour changed on x86 after the powerp

Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

2024-06-13 Thread Nysal Jan K.A.
On Thu, Jun 13, 2024 at 09:34:10PM GMT, Michael Ellerman wrote: > "Nysal Jan K.A." writes: > > From: "Nysal Jan K.A" > > > > After the addition of HOTPLUG_SMT support for PowerPC [1] there was a > > regression reported [2] when enabling SMT. > > This implies it was a kernel regression. But it ca

Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

2024-06-13 Thread Michal Suchánek
On Thu, Jun 13, 2024 at 09:34:10PM +1000, Michael Ellerman wrote: > "Nysal Jan K.A." writes: > > From: "Nysal Jan K.A" > > > > After the addition of HOTPLUG_SMT support for PowerPC [1] there was a > > regression reported [2] when enabling SMT. > > This implies it was a kernel regression. But it

Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

2024-06-13 Thread Michael Ellerman
"Nysal Jan K.A." writes: > From: "Nysal Jan K.A" > > After the addition of HOTPLUG_SMT support for PowerPC [1] there was a > regression reported [2] when enabling SMT. This implies it was a kernel regression. But it can't be a kernel regression because previously there was no support at all for