Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak

2019-05-07 Thread Alex Williamson
On Tue, 7 May 2019 09:01:45 +0200 Greg Kurz wrote: > On Tue, 7 May 2019 11:52:44 +1000 > Sam Bobroff wrote: > > > On Mon, May 06, 2019 at 03:58:45PM -0600, Alex Williamson wrote: > > > On Fri, 19 Apr 2019 17:37:17 +0200 > > > Greg Kurz wrote: > > > > > > > If vfio_pci_register_dev_regio

Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak

2019-05-07 Thread Greg Kurz
On Tue, 7 May 2019 11:52:44 +1000 Sam Bobroff wrote: > On Mon, May 06, 2019 at 03:58:45PM -0600, Alex Williamson wrote: > > On Fri, 19 Apr 2019 17:37:17 +0200 > > Greg Kurz wrote: > > > > > If vfio_pci_register_dev_region() fails then we should rollback > > > previous changes, ie. unmap the A

Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak

2019-05-06 Thread Sam Bobroff
On Mon, May 06, 2019 at 03:58:45PM -0600, Alex Williamson wrote: > On Fri, 19 Apr 2019 17:37:17 +0200 > Greg Kurz wrote: > > > If vfio_pci_register_dev_region() fails then we should rollback > > previous changes, ie. unmap the ATSD registers. > > > > Signed-off-by: Greg Kurz > > --- > > Applie

Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak

2019-05-06 Thread Alex Williamson
On Fri, 19 Apr 2019 17:37:17 +0200 Greg Kurz wrote: > If vfio_pci_register_dev_region() fails then we should rollback > previous changes, ie. unmap the ATSD registers. > > Signed-off-by: Greg Kurz > --- Applied to vfio next branch for v5.2 with Alexey's R-b. Thanks! Alex > drivers/vfio/pci

Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak

2019-04-26 Thread Alexey Kardashevskiy
On 20/04/2019 01:37, Greg Kurz wrote: > If vfio_pci_register_dev_region() fails then we should rollback > previous changes, ie. unmap the ATSD registers. > > Signed-off-by: Greg Kurz > --- > drivers/vfio/pci/vfio_pci_nvlink2.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dri