Re: [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver

2010-08-02 Thread Greg KH
On Mon, Aug 02, 2010 at 03:12:48PM +0200, Uwe Kleine-König wrote: > On Mon, Aug 02, 2010 at 02:51:36PM +0200, Julia Lawall wrote: > > > diff --git a/drivers/usb/gadget/amd5536udc.c > > > b/drivers/usb/gadget/amd5536udc.c > > > index 731150d..c266c1e 100644 > > > --- a/drivers/usb/gadget/amd5536udc

Re: [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver

2010-08-02 Thread Michał Nazarewicz
Some random thoughts, one bug and mostly just minor comments: @@ -1954,13 +1954,14 @@ static int setup_ep0(struct udc *dev) } /* Called by gadget driver to register itself */ -int usb_gadget_register_driver(struct usb_gadget_driver *driver) +int usb_gadget_probe_driver(struct usb_gadget_driver

Re: [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver

2010-08-02 Thread Uwe Kleine-König
On Mon, Aug 02, 2010 at 02:51:36PM +0200, Julia Lawall wrote: > > diff --git a/drivers/usb/gadget/amd5536udc.c > > b/drivers/usb/gadget/amd5536udc.c > > index 731150d..c266c1e 100644 > > --- a/drivers/usb/gadget/amd5536udc.c > > +++ b/drivers/usb/gadget/amd5536udc.c > > @@ -1954,13 +1954,14 @@ sta

Re: [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver

2010-08-02 Thread Julia Lawall
> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c > index 731150d..c266c1e 100644 > --- a/drivers/usb/gadget/amd5536udc.c > +++ b/drivers/usb/gadget/amd5536udc.c > @@ -1954,13 +1954,14 @@ static int setup_ep0(struct udc *dev) > } > > /* Called by gadget driver to