Re: [PATCH] ucc_geth: fix ethtool set ring param bug

2010-08-31 Thread Ben Hutchings
On Tue, 2010-08-31 at 23:16 +0800, Liang Li wrote: > On Tue, Aug 31, 2010 at 03:41:22PM +0100, Ben Hutchings wrote: > > On Mon, 2010-08-30 at 22:47 +0800, Liang Li wrote: > > > It's common sense that when we should do change to driver ring > > > desc/buffer etc only after 'stop/shutdown' the device

Re: [PATCH] ucc_geth: fix ethtool set ring param bug

2010-08-31 Thread Liang Li
On Tue, Aug 31, 2010 at 03:41:22PM +0100, Ben Hutchings wrote: > On Mon, 2010-08-30 at 22:47 +0800, Liang Li wrote: > > It's common sense that when we should do change to driver ring > > desc/buffer etc only after 'stop/shutdown' the device. When we > > do change while devices/driver is running, ke

Re: [PATCH] ucc_geth: fix ethtool set ring param bug

2010-08-31 Thread Ben Hutchings
On Mon, 2010-08-30 at 22:47 +0800, Liang Li wrote: > It's common sense that when we should do change to driver ring > desc/buffer etc only after 'stop/shutdown' the device. When we > do change while devices/driver is running, kernel oops occur: [...] > diff --git a/drivers/net/ucc_geth_ethtool.c b/